WillyXJ / facileManager

A modular suite of web apps built with the sysadmin in mind.
www.facilemanager.com
GNU General Public License v2.0
85 stars 37 forks source link

[ISSUE] Error zones.conf.all: file not found appear in preview configuration when recursion enabled #572

Closed andzham closed 1 year ago

andzham commented 1 year ago

Please prefix your issue title with one of the following: [BUG], [ISSUE], [FEATURE REQUEST], [MODULE REQUEST], [OTHER].

Replace everything between stars with current version of your facileManager and module installations:
fM Version : 4.3.0

Version : **5.2.1** **In raising this issue, I confirm the following (please check boxes, eg [X]):** - [x] I have read and understood the [contributors guide](https://github.com/WillyXJ/facileManager/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present. - [x] I have checked that the issue I'm posting isn't already reported. - [x] I have checked that the issue I'm posting isn't already solved and no duplicates exist in [closed issues](https://github.com/WillyXJ/facileManager/issues?q=is%3Aissue+is%3Aclosed) and [opened issues](https://github.com/WillyXJ/facileManager/issues) - [x] I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion. --- **(BUG | ISSUE) Expected Behavior:** no error/warning shows up when recursion set to enabled **(BUG | ISSUE) Actual Behavior:** with recursion set to yes in server options warning %zonesdir/zones.conf.all appears in configuration preview before roothints **(BUG | ISSUE) Steps to reproduce:** add option recursion yes and after that press preview configuration warning about zones.conf.all file not found shown in configuration preview window with recursion set to no - all ok
WillyXJ commented 1 year ago

I'm currently unable to reproduce this issue. Would you please provide a screenshot of the error?

andzham commented 1 year ago

Screens of issue from configuration preview window:

image image

Additional information: we have views defined for other server ( at server levvel) in same instance of fmDNS, but no views defined for server at question, as well we are just trying to get initial configuration build ready, so server is currently disabled. if we assign views to server in question - no error anymore ( of course instead of zones.conf.all zone conf files for views are created) in other instance of fmDNS where no views used at all, enabling recursion for some indivvidual server doesn't cause metioned error

WillyXJ commented 1 year ago

Thanks for the screen grabs. I see now the message for you comes from the named checks. However, I'm still unable to reproduce this. Here are my steps:

  1. Fresh installation with two name servers (test-server1 and test-server2)
  2. Enable named checks in the settings
  3. Views -> Select test-server1 from the servers list
  4. Create view (test-view) only for test-server1
  5. Create zone in All Views, but associate it with test-server1
  6. Preview the config individually for both servers and I'm not getting that message.

What additional steps do I need to take?

In addition, can you confirm your config preview does not have any file named "zones.conf.all" in it?

andzham commented 1 year ago

For your test setup after step 4. Config -> Options -> All views, Select test-server2 -> Add new Global Option -> Option Name : Recursion, Option value: Yes for step 5. Create zone in test-view associating it with test-server1 proceed with step 6 and for test-server2 error/warning message are show up and yes confirm there is no file zones.conf.all in preview apart of red colored include directive, as shown in previous screen grab.

WillyXJ commented 1 year ago

Hmmm even with those steps I'm still getting a good config. Your config preview does not have zones.conf.all, but does it have zones.conf. instead? Or maybe you don't have any zone definition files in the preview.

WillyXJ commented 1 year ago

If I delete the default zones (localhost, 0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa, and 0.0.127.in-addr.arpa) then I'm able to get the error.

Until the next release comes with the fix, you can create a dummy zone that doesn't have a SOA and/or NS records as a workaround. This dummy zone will exist in the database, but won't get built on any of your servers, but it will allow zones.conf.all to be built.

andzham commented 1 year ago

Thank you very much , adding back 0.0.127.in-addr.arpa for all servers solved issue

WillyXJ commented 1 year ago

This is now fixed in fmDNS 5.3.0 and later.