WillyXJ / facileManager

A modular suite of web apps built with the sysadmin in mind.
www.facilemanager.com
GNU General Public License v2.0
88 stars 37 forks source link

[ISSUE] Zone reload php-warning appear BUT zone does not reload #610

Closed sergor75 closed 7 months ago

sergor75 commented 7 months ago

fM Version : 4.6.0 fM DNS Version : 6.0.1

Today I updated my test installation (fm server and client) to version 4.6.0

I change the TTL of an arbitrary entry in one of the zones, reload the zone - a warning window appears (see attachments), but the zone is not reloaded and updates do not arrive to the client

fm_4 6 0_zone_reload_warning fm_4 6 0_zone_reload_warning2
sergor75 commented 7 months ago

image

WillyXJ commented 7 months ago

Are you using server groups for that zone?

WillyXJ commented 7 months ago

If you use server groups, the fix will be to replace https://github.com/WillyXJ/facileManager/blob/0017d8c885c064f33cda8a26b035a1b015a0288c/server/fm-modules/fmDNS/classes/class_zones.php#L1369 with

$name_servers = $this->getNameServers($domain_name_servers, array('masters'));

This will be included in the next release. If server groups are not being used then I'll need to find a different solution.

sergor75 commented 7 months ago

yes, this fix helped, thank you very much

WillyXJ commented 7 months ago

This is now fixed in fmDNS 6.0.2 and later.