WillyXJ / facileManager

A modular suite of web apps built with the sysadmin in mind.
www.facilemanager.com
GNU General Public License v2.0
84 stars 37 forks source link

[BUG] Error converting TXT record containing email address from db to conf file (serious issue since it may be a dmarc record) #617

Closed gianlucagiacometti closed 3 months ago

gianlucagiacometti commented 4 months ago

facileManager v4.6.1 fmDNS v6.0.3 PHP 8.1.2


I create a TXT record:

Record: _dmarc TTL: 3600 Value: v=DMARC1; p=quarantine; ri=3600; rua=mailto:postmaster@mydomain.com; ruf=mailto:postmaster@mydomain

(BUG | ISSUE) Expected Behavior:

The resulting conf file should be: _dmarc.mydomain.com. 3600 IN TXT ("v=DMARC1; p=quarantine; ri=3600; rua=mailto:postmaster@mydomain.com; ruf=mailto:postmaster@mydomain.com")

(BUG | ISSUE) Actual Behavior:

The resulting conf file is: _dmarc.mydomain.com. 3600 IN TXT ("v=DMARC1; p=quarantine; ri=3600; rua=mailto:postmastermydomain.com.mydomain.com; ruf=mailto:postmastermydomain.com.mydomain.com")

(BUG | ISSUE) Steps to reproduce:

Just create the record with a "@". The "@" is stripped away and the domain name is added instead

gianlucagiacometti commented 4 months ago

I found the error and created a pull request

WillyXJ commented 4 months ago

This is caused by #593 which does want to use @ in the TXT record as the domain name. A new solution will need to be implemented.

WillyXJ commented 3 months ago

This is now fixed in fmDNS 6.0.4 and later.