WillyXJ / facileManager

A modular suite of web apps built with the sysadmin in mind.
www.facilemanager.com
GNU General Public License v2.0
88 stars 37 forks source link

[BUG] Reverse zone edit: Uncaught TypeError: explode(): Argument #2 ($string) must be of type string #629

Closed imyller closed 4 months ago

imyller commented 4 months ago

fM Version : 4.6.2 fmDNS Version : 6.0.5

Debian 12 (Bookworm) PHP 8.2.18 Apache 2.4.59

In raising this issue, I confirm the following (please check boxes, eg [X]):


(BUG | ISSUE) Expected Behavior:

Zone edit works.

(BUG | ISSUE) Actual Behavior:

Fatal error: Uncaught TypeError: explode(): Argument #2 ($string) must be of type string, array given in /opt/facileManager/server/fm-modules/fmDNS/classes/class_records.php:923 Stack trace: #0 /opt/facileManager/server/fm-modules/fmDNS/classes/class_records.php(923): explode() #1 /opt/facileManager/server/fm-modules/fmDNS/ajax/getData.php(283): fm_dns_records->getServerZoneData() #2 /opt/facileManager/server/fm-modules/facileManager/ajax/getData.php(143): include('...') #3 {main} thrown in /opt/facileManager/server/fm-modules/fmDNS/classes/class_records.php on line 923

Click zone to edit records:

editerr1

Results in:

editerr3

(BUG | ISSUE) Steps to reproduce:

WillyXJ commented 4 months ago

This is now fixed in fmDNS 6.0.6 and later.

imyller commented 3 months ago

Fix caused regression: https://github.com/WillyXJ/facileManager/issues/630#issuecomment-2176274169