search

Wilm0r / giggity

Generic Android conference schedule viewer
https://gaa.st/giggity
GNU General Public License v2.0
102 stars 110 forks source link

FOSSY 2023: Use schedule in XML converted from the JSON version #283

Closed EdwardBetts closed 1 year ago

EdwardBetts commented 1 year ago

Reads a version of the schedule in XML that has been generated from the JSON version of the schedule.

The XML version is being regenerated regularly.

This gives more detail that the ICS version.

github-actions[bot] commented 1 year ago

New: FOSSY 2023 (use this one!) Removed: FOSSY 2023 File passed validation! \o/

Wilm0r commented 1 year ago

Oh nice!! On my phone right now, can merge shortly, but one warning: this will invalidate any selections people may have made. Is that still safe?

EdwardBetts commented 1 year ago

I think it is safe, the ICS version hasn't been there for long.

Wilm0r commented 1 year ago

OK, let's take the risk.

But one more issue, and this is kinda a Giggity bug in a way, but people who used Giggity over the past days will still have the old entries in their menu too. :(

We could either have extra files for the old two URLs with "(old, do not use)" titles which stinks because it'll show up even for people who so far haven't opened Giggity, or maybe just add "(use this one!)" or something to the title of this entry. I think I like that last option more.

I used to use an explicit primary key for schedules instead of their URL but it was tedious in other ways and didn't seem to be worth keeping. I should perhaps reconsider.. IIRC that was before I split the menu entries file with the centralised auto-generator that could now generate these primary keys when absent..

EdwardBetts commented 1 year ago

I saw this bug with the switch to the ICS schedule. I agree the second option is better.

Maybe you could use the menu filename (fossy_2023.json) as the primary key.

Wilm0r commented 1 year ago

Maybe you could use the menu filename (fossy_2023.json) as the primary key.

Yeah exactly. That's the best option now with the split menu files. I just need to figure out how to transition this cleanly with bw compatibility etc.

Can you update your PR with option 2 then? Ready to merge whenever you are :)

EdwardBetts commented 1 year ago

I've made the change.