search

Wilm0r / giggity

Generic Android conference schedule viewer
https://gaa.st/giggity
GNU General Public License v2.0
101 stars 104 forks source link

Fehler beim Laden "34c3": Network I/O problem: java.io.IOException: Download error #41

Closed Wikinaut closed 6 years ago

Wikinaut commented 6 years ago

When scanning the QR code of https://events.ccc.de/congress/2017/Fahrplan/qrcode.html , I got "Fehler beim Laden".

schumar commented 6 years ago

I managed to add the schedule by manually entering the URL https://events.ccc.de/congress/2017/Fahrplan/schedule.xml

The QR code only says //events.ccc.de/congress/2017/Fahrplan/, so I'm not sure if this is actually an issue with Giggity

Wilm0r commented 6 years ago

Huh, that's pretty weird yeah :-( Guess the best fix is to get it into menu.json IOW merge https://github.com/Wilm0r/giggity/pull/43 so people don't have to bother with any QR at all.

Wilm0r commented 6 years ago

Ha, even here on https://fahrplan.events.ccc.de/congress/2017/Fahrplan/schedule.xml I see this:

//fahrplan.events.ccc.de/congress/2017/Fahrplan/

I .... guess this is a valid URL in some places, it kinda is a valid relative URL in browsers/HTML AFAIK. But I'm pretty sure a statement liket his one should have absolute URLs...

Anyway, not a Giggity bug. "Fixing" this through menu.json now. Thanks for the report anyway :-)

Wikinaut commented 6 years ago

Anleitung für @erdgeist

Bitte diesen QR Code qr

mit der Url https://fahrplan.events.ccc.de/congress/2017/Fahrplan/schedule.xml

auf Deiner Seite https://events.ccc.de/congress/2017/Fahrplan/qrcode.html

platzieren.

Wikinaut commented 6 years ago

@Wilm0r Thank you all. I informed the CCC team to fix their QR code!

Wikinaut commented 6 years ago

@erdgeist told me, I should notify frab. Done with https://github.com/frab/frab/issues/386

manno commented 6 years ago

This was put there intentionally, but I don't know why. Changed it to a full URL with protocol. frab should validate this in the future, maybe.

mmuman commented 6 years ago

The "//..." scheme is on purpose I think, it's a protocol-relative URL, that is, it assumes to be the same protocol as the referrer. This is to avoid mixed content in web pages. We should probably prepend https: there.

Wilm0r commented 6 years ago

Yeah I know, see my comment above at https://github.com/Wilm0r/giggity/issues/41#issuecomment-352439195 - I think it's done in some contexts where IMHO relative URLs shouldn't be valid, including the QR code for example (no context from where to support a relative URL, right?).

mmuman commented 6 years ago

Indeed, there's no referrer there.