Wilsonator123 / Secure-Blog-Page

DSS Projecy
1 stars 0 forks source link

#16 Create Frontend Login Page #44

Closed raiiinyy closed 3 months ago

raiiinyy commented 4 months ago

TODO:

Wilsonator123 commented 4 months ago

Just as a comment can we keep it to bullet points / checklist. Im lazy so its easier to see clear cut changes

This also means if there are changes left to implement we can see what they are

raiiinyy commented 4 months ago

Yes, that is very fair, I'll do that in future requests.

Wilsonator123 commented 3 months ago

resolves #16

Wilsonator123 commented 3 months ago

Untitledvideo-MadewithClipchamp7-ezgif com-video-to-gif-converter

I dont really like this @thealextaft what are your thoughts? I think we could use the yellow outline or at least a different color

thealextaft commented 3 months ago

Yellow outline please when :hover:

Wilsonator123 commented 3 months ago

Yellow outline please when :hover:

@raiiinyy you can see this in my branch called testing-password-meter

Wilsonator123 commented 3 months ago

image

image

Your designs don't match Alex's

Wilsonator123 commented 3 months ago

image

image

These dont match

Wilsonator123 commented 3 months ago

Please can you follow the designs Alex has made on the figma more closely

Wilsonator123 commented 3 months ago

image image

You are missing padding and correct margins sizes here

Wilsonator123 commented 3 months ago

image

This shouldn't turn yellow on hover

Wilsonator123 commented 3 months ago

From memory the changes needed were

Wilsonator123 commented 3 months ago

image

image

The forms are different sizes

Wilsonator123 commented 3 months ago

image

This isnt in the right postion (i assume its due to different screen sizes)

Wilsonator123 commented 3 months ago

There is still no background color for the input fields

raiiinyy commented 3 months ago

should be for login but realised i forgot for signup and forgotten password so will add now

Wilsonator123 commented 3 months ago

Assuming thats the case I will approve... finally!!