search

Wilto / Dynamic-Carousel

A carousel plugin built for responsive layouts. There are many like it, but this one is mine.
matmarquis.com/carousel/
472 stars 112 forks source link

data-autorotate #22

Closed jpamental closed 13 years ago

jpamental commented 13 years ago

Hey Matt - any chance you might have a quick fix for data-autorotate when using the pagination=true/addNav=false (little dots)

Launching the site I've been working on with your plugin in Drupal this afternoon and it would be nice to get that bit sorted if at all possible.

Thanks again -

Jason

Wilto commented 13 years ago

Should be squared in the latest version—sorry, should’ve sent you a heads-up!

Sent from my iPhone

On Aug 12, 2011, at 9:01, jpamental reply@reply.github.com wrote:

Hey Matt - any chance you might have a quick fix for data-autorotate when using the pagination=true/addNav=false (little dots)

Launching the site I've been working on with your plugin in Drupal this afternoon and it would be nice to get that bit sorted if at all possible.

Thanks again -

Jason

Reply to this email directly or view it on GitHub: https://github.com/Wilto/Dynamic-Carousel/issues/22

jpamental commented 13 years ago

Awesome - thanks! Question - is it possible to call that from the script where you pass in 'autoNav: true' etc, or only from the HTML? Just curious...

Wilto commented 13 years ago

The data- attribute only, for the time being—seemed to make the most sense, in terms of keeping such things granular.

jpamental commented 13 years ago

Got it. Ironically, it's far easier for me to put it in the JS file than modify the 'view' output in Drupal! Not impossible by any stretch - just more separate view files. It'd be cool to figure out a way to modularize it, but my brain isn't up for that yet.