search

Wilyicaro / BetterFurnacesReforged

8 stars 14 forks source link

1.16.5 Server crash with BetterFurnaces 1.1.2 #135

Closed cc004 closed 9 months ago

cc004 commented 9 months ago

partial log:

java.lang.NoSuchMethodError: 'boolean net.minecraft.util.registry.DefaultedRegistry.func_212607_c(net.minecraft.util.ResourceLocation)'
    at net.minecraft.tileentity.TileEntity.handler$bbb000$loadStatic(TileEntity.java:1529) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:itemblacklist.mixins.json:TileEntityMixin,pl:mixin:APP:immersiveengineering.mixins.json:accessors.TileEntityAccess,pl:mixin:APP:betterfurnaces-common.mixins.json:BlockEntityMixin,pl:mixin:APP:architectury.mixins.json:MixinBlockEntity,pl:mixin:A,pl:runtimedistcleaner:A}
    at net.minecraft.tileentity.TileEntity.func_235657_b_(TileEntity.java) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:itemblacklist.mixins.json:TileEntityMixin,pl:mixin:APP:immersiveengineering.mixins.json:accessors.TileEntityAccess,pl:mixin:APP:betterfurnaces-common.mixins.json:BlockEntityMixin,pl:mixin:APP:architectury.mixins.json:MixinBlockEntity,pl:mixin:A,pl:runtimedistcleaner:A}

https://github.com/Wilyicaro/BetterFurnacesReforged/blob/517658562466df266416ff94db17ea4e3a7ee79f/common/src/main/java/wily/betterfurnaces/mixin/BlockEntityMixin.java#L29

the method net.minecraft.util.registry.DefaultedRegistry.containsKey doesn't work on servers

          It looks like this is caused by the file "ItemExistsLootCondition" and specifically the 34th line, containsKey() is a sided method and only works on the client side, so it causes a crash when run on a server. I had the same problem, but only once I moved everything to a local server. I figure the two people above are also having this issue on a server as well, but hopefully this helps make it easy for the devs to fix the issue!

Originally posted by @Mario90900 in https://github.com/MoonflowerTeam/anchor/issues/3#issuecomment-1139265804

Wilyicaro commented 9 months ago

Thanks for reporting this crash, and practically solving it for me. It will be fixed in the 1.16.5-1.1.3 version