Wilyicaro / BetterFurnacesReforged

8 stars 14 forks source link

[Bug/Glitch]Issue with Pickaxes with ForgeConfigAPIPort #153

Closed BioMasterZap closed 6 months ago

BioMasterZap commented 6 months ago

Better Furnaces Reforged Version

1.20.4-1.0-fabric

Mod Loader Version

Fabric Loader 0.15.6

Bug/Glitch Occurrence Context

With BetterFurnaces-1.20.4-1.0 (Architectury-11.0.12, FactoryAPI-1.20.2-2.1.1, and Fabric-API-0.96.0) and ForgeConfigAPIPort-v20.4.3, if betterfurnacesreforged-common sets "enable_ultimatefurnaces" to false, for some reason all pickaxes get set to a mining speed of 1 and are unable to harvest blocks. If ForgeConfigAPIPort is removed or if "enable_ultimatefurnaces" is set to true (default), pickaxes work as normal.

This was originally noticed in a Mod Pack, but the issue was confirmed in a test profile with only the mods listed above. It seemed to apply to all pickaxes, including one modded one, but was primarily tested with a diamond pickaxe. ForgeConfigAPIPort is using default configs. It is possible that other config options may also cause this issue or that something else is a factor, but this is as much as I've been able to figure out from my testing.

I tried to test this with BetterFurnaces-1.20.4-1.0.1, but that prompts me to use Factory API v2.1.3 or later and the latest release I can find is v2.1.1. So apologies if this issue was resolved in that version, but I did not see anything on the changelog that suggested it would be resolved and I cannot get that version to launch but to outdated dependencies.

Crash Report

No response

What happened wrong?

With the ForgeConfigAPIPort-v20.4.3 mod, setting "enable_ultimatefurnaces" to false for some reason sets the mining speed of all pickaxes to 1, making all blocks extremely slow to break and resulting in no block drops. If ForgeConfigAPIPort is removed from mods or if "enable_ultimatefurnaces" is set to true (default), pickaxes return to working as normal.

Wilyicaro commented 6 months ago

This issue is known, the enable ultimate furnaces option is unstable, because for some reason tags with unregistered blocks or items aren't read by complete, as the ultimate furnaces aren't registered when this option is disabled, the vanilla tags for breakable blocks aren't read and it causes this issue. About the Factory API 2.1.3, this is a dev version and it is a bug from this version 1.0.1 of BFR for 1.20.4, it will be fixed in the next version.