Wilyicaro / BetterFurnacesReforged

8 stars 15 forks source link

Auto-Input and Factory Upgrades not checking inventories 1.18.2 #43

Closed Staegrin closed 2 years ago

Staegrin commented 2 years ago

Version BetterFurnacesReforged-1.18.2-1.2.3 & Ultimate-Furnaces-BFR-1.18.2-1.0 Forge 40.1.52 Minecraft 1.18.2 Neither the furnaces or the forges equipped with an Auto-Input or Factory Upgrade will auto pull smelt-able items from inventories. Until an item is modified in the furnace/forge. 2022-07-01_01 25 27 A furnace/Forge will only pull from the adjacent inventory if first an item is hoppered in or placed in manually. When the fuel slot has space, the fuel will be extracted automatically. Anything that can be smelted will not be detected until something changes inside the furnace/forge. 2022-07-01_01 30 17 The factory upgrade is set to Auto Input true, for the correct side and Redstone Ignored 2022-07-01_01 31 38 3 stacks of copper dust not being extracted. 2022-07-01_01 32 28 2022-07-01_01 32 29 Put in one dust into the top slot or remove some of the fuel and suddenly the furnace/forge will start to extract from the inventory next to it.

Wilyicaro commented 2 years ago

Have you tried using the newest version(1.18.2-1.2.4)? Soon I will analyze to find a solution for this bug

Wilyicaro commented 2 years ago

Sorry, but I did exactly the same block setup as you did, and the same factory upgrade configuration, and I didn't find this bug, maybe I fixed it in this new version and don't remember.

Staegrin commented 2 years ago

Using latest Ultimate-Furnaces-BFR-1.18.2-1.0.1 BetterFurnacesReforged-1.18.2-1.2.5 Still happening. Inventory of the furnace needs to be changed in some way before the inventory next to it gets checked. In your setup, did you wait for the fuel to fill up? Before adding smeltable items into the inventory next to the furnace? Because the furnace will detect and extract fuel from an adjacent inventory without any problem. This filling up on fuel will also make the furnace check for smeltable items. When the fuel is full and nothing further changes it will stop checking adjacent inventories.

Wilyicaro commented 2 years ago

The furnace was already fueled and idle, with no inventory changes, and auto-input was working normally

Staegrin commented 2 years ago

Just tried in a world with only Ultimate-Furnaces-BFR-1.18.2-1.0.1 BetterFurnacesReforged-1.18.2-1.2.5 jei-1.18.2-9.7.0.196 Fueled up 2022-07-01_22 31 48 Raw iron in the barrel 2022-07-01_22 31 52

2022-07-01_22 31 54 Put in one Raw iron 2022-07-01_22 32 11 Now suddenly it notices all the other raw iron and starts extracting from the barrel 2022-07-01_22 32 12

Wilyicaro commented 2 years ago

https://user-images.githubusercontent.com/81383021/176969301-f5e70628-cbbc-429f-b753-3fd27a5af537.mp4

Staegrin commented 2 years ago

Just tested it. It works if the fuel is not full. In your case 37 coal. Then the automation works. As soon as there are 64 coal, it no longer detects smeltable items in the adjacent inventory.

Wilyicaro commented 2 years ago

It has 37 coals because before they were consumed when starting the auto-input they had 64 coals 😒

Staegrin commented 2 years ago

Same with the Fuel Liquid upgrade 2022-07-01_23 33 59 2022-07-01_23 34 08 Plenty of lava in the tank and iron dust in the adjacent inventory 2022-07-01_23 34 15 Remove the full lava bucket, add some Iron dust into the adjacent inventory and now the Ultimate Forge can detect smeltable items and import them.

Staegrin commented 2 years ago

So for some reason the fuel slot being full of fuel stops the upgrade from checking if smeltable material gets added to adjacent inventories.

Wilyicaro commented 2 years ago

Thanks for reporting this bug, I already found the problem, and I'll post the fix soon.

Staegrin commented 2 years ago

My pleasure. It was a strange edge case.

Wilyicaro commented 2 years ago

Fixed in version 1.18.2-1.2.6

Staegrin commented 2 years ago

Seems fully fixed. Thanks for the hard work.

Wilyicaro commented 2 years ago

My pleasure to make the fix ;)