Wilyicaro / Legacy-Minecraft

This mod adapts all the features from old Minecraft Legacy Console edition
MIT License
148 stars 40 forks source link

Autosaving partially continues after disabling #462

Closed Cjnator38 closed 2 months ago

Cjnator38 commented 3 months ago

When disabling autosave and manually saving at any point afterwards, it will partially continue make new saves. The autosaves will continue showing the icon and will make a new save, but the blocks in the save are reverted to how they were in the previous manual save. Items in the inventory obtained following the manual save will remain in the inventory. Autosaving also continues on a fresh L4J instance, although I can't confirm if blocks remaining from a manual save is an issue there.

https://github.com/Wilyicaro/Legacy-Minecraft/assets/39870226/d69740d2-f7b4-4604-9833-fafdce6b154f

bugsbugsbugsLCE commented 3 months ago

This issue might explain the inconsistencies I have experienced when having this feature disabled. I once made an armorer villager, traded with it, exitted without saving an upon reentering I still had the items I got from trading but the blast furnace workstation was gone. (See conversation in discord https://discord.com/channels/1203542640008892498/1203542640470138907/1241862006898954361)

Wilyicaro commented 2 months ago

Fixed in version 1.7, thanks for reporting.