Wilyicaro / Legacy-Minecraft

This mod adapts all the features from old Minecraft Legacy Console edition
MIT License
148 stars 40 forks source link

Various issues with Dog easter egg #468

Closed sunsetbear closed 2 months ago

sunsetbear commented 3 months ago
  1. the tick length of a disc is specified in code, to determine for how long music note particles should spawn, for how long to emit a redstone pulse to a comparator, and for how long to let the audio play before forcibly stopping it. This tick length appears to have gone unmodified leading to Dog never actually playing in-game.
  2. cat.ogg is in stereo, which means directional panning and positional volume scaling fail completely when the disc is played in-game
  3. The bitrate of the file hovers around 100 kpbs, when cat.ogg itself was initially 70kpbs. This leads to filesize bloat especially considering the near double length of the song.

Here's an ogg file that fixes 2 and 3 and is also mastered similar to the original cat.ogg instead of being a straight rip of c418's stereo masters- this is important to keep a consistent listening volume in-game. You can fix 1. by doing some math

Wilyicaro commented 3 months ago

Thank you for your help with the correction, in fact I didn't even obtain the audio used in the cat music disc, AgentMindStorm provided it to me along with other resources

Wilyicaro commented 2 months ago

Fixed in version 1.7, thanks for reporting.