WinDanesz / AncientSpellcraft

An extension mod for the Electroblob's Wizardry Minecraft 1.12.2 mod
https://www.curseforge.com/minecraft/mc-mods/ancient-spellcraft
GNU General Public License v3.0
7 stars 15 forks source link

[Bug] Sage spells json configurations #161

Open KnightCa opened 10 months ago

KnightCa commented 10 months ago

Is there an existing issue for this?

Observed behavior

Ancient Spells asset/spells configs may need some adjusting:

Available in Treasure Chests, by Trade, or by Looting

The following spells are set as Sage spells, but are available by either Treasure, Trade, or Loot. Are these errors (ie they all should be set to only be gained by the experiment/scribe spell)?

Gained by Treasure, Trade, Loot:

Gained by Treasure, Loot:

NPC Sages

These Sage spells are allowed for NPC Sages: Appears like they should not be allowed.

These Sage spells are not allowed for NPC Sages: Appears like they should be allowed.

Dispensers

These Sage spells are not allowed by Dispensers: Appears like they should be allowed.

These Sage spells are allowed for Dispensers: Appears like they should not be allowed.

Expected behaviour

I expected all Sage spells to be unavailable by Treasure, Trade, or Loot. You would have to use Scribe to discover them.

I expected that Sage spells that summoned minions, attack spells, and allowed options for movement to be allowed for NPC Sages.

I expected that Sage spells that don't seem to be something a NPC would cast to be disallowed.

I thought that spells that require interaction with a users playerdata (such as using your Tome, selected teleportation circle, or replacing a spell slot) would not be found in Dispensers.

I thought that spells that had a clear direct effect not requiring player data would be able to be used in Dispensers.

Steps to reproduce

  1. Open up Ancient Spellcraft json and look at asset/spells for the spells mentioned.

Environment (Singleplayer/Server, etc.)

Issue present on both sides

Mod version

1.5.11-PreRelease-4f214c5

Forge version

1.12.2-forge-14.23.5.2860

Other mods

Electroblob Wizardry 4.3.12

github-actions[bot] commented 10 months ago

This issue is potentially a duplicate of one of the following issues:

github-actions[bot] commented 9 months ago

This issue is potentially a duplicate of one of the following issues:

github-actions[bot] commented 9 months ago

This issue is potentially a duplicate of one of the following issues:

github-actions[bot] commented 9 months ago

This issue is potentially a duplicate of one of the following issues: