WinDanesz / AncientSpellcraft

An extension mod for the Electroblob's Wizardry Minecraft 1.12.2 mod
https://www.curseforge.com/minecraft/mc-mods/ancient-spellcraft
GNU General Public License v3.0
7 stars 15 forks source link

[Bug] Awaken Tome allows caster to duplicate a Sage Tome #182

Open KnightCa opened 1 year ago

KnightCa commented 1 year ago

Is there an existing issue for this?

Observed behaviour

Two related issues that have to do with the awakened Sage tome being able to be retrieved by a empty hand.

  1. You can duplicate a awakened Sage Tome by using two Tome Controllers, gained by using a empty hand to regain the Sage Tome while keeping the Tome Controller (this could be solved by having the Tome Controller disappear when the Sage Tome returns to the inventory by any means, such as by right-clicking with a empty hand).

  2. When casting Awaken Tome, if you hold down the right-click when casting.. you end up with the Sage Tome back in your hand (this could be solved by having a cooldown applied to the use of the Tome Controller).

This is due to the current interaction with the awakened Sage Tome:

  1. When you right-click the Tome Controller, the Sage Tome will appear in your hot bar and the Tome Controller will vanish (this works great).
  2. If you right-click on the awakened Sage Tome with a empty hand, the Sage Tome will go into your hot bar and the Tome Controller will remain in inventory (not so good).

Expected behaviour

When your Sage Tome returns into your inventory, the Tome Controller should disappear.

When you cast Awaken Tome, a short cooldown on the Tome Controller is needed to avoid picking the Sage Tome right back up (by right-clicking the Tome Controller that takes its place).

Steps to reproduce

Issue 1: Sage Tome duplication

  1. Join a Server
  2. Wear Sage Robes and put the Awaken Tome spell on a Sage tome
  3. Use the Awaken Tome spell to awaken the Sage tome, which results in a Tome Controller appearing in your inventory
  4. Right-click the awakened Sage tome while holding nothing in your hands
  5. You now have the Tome Controller and the Sage tome
  6. Use the Awaken Tome spell to awaken the Sage tome a second time, which results in a second Tome Controller appearing in your inventory (total of 2 Tome Controllers and 1 awakened Sage tome)
  7. Put one Tome Controller in your main hand and one in your offhand
  8. Right click the Tome Controller, resulting in 2 Sage tomes (duplicated) in your inventory

Issue 2: Sage tome doesn't stay awakened with a long cast

  1. Join Server
  2. Put on Sage Robes and add Awaken Tome to Sage tome
  3. Cast Awaken Tome and continue holding right-click (as if for a spell requiring a charge-up)

Environment (Singleplayer/Server, etc.)

Issue present on both sides

Mod version

1.5.10

Forge version

1.12.2-forge-14.23.5.2860

Other mods

No response