WinDanesz / AncientSpellcraft

An extension mod for the Electroblob's Wizardry Minecraft 1.12.2 mod
https://www.curseforge.com/minecraft/mc-mods/ancient-spellcraft
GNU General Public License v3.0
7 stars 15 forks source link

[Bug] Tame Animal cannot tame Donkey/Horse/Llama/Mule while near animal #191

Open KnightCa opened 9 months ago

KnightCa commented 9 months ago

Is there an existing issue for this?

Observed behaviour

When trying to use Tame Animal next to a a animal that normally requires mounting to be tamed (Donkey/Horse/Llama/Mule), the animal does not become tamed. You have to move a good distance away to be able to get Tame Animal to work to tame them.

This may be a issue with right-clicking close to a mountable animal conflicting with casting the spell. Sneak casting doesnt change the issue.

The spell works correctly when next to a Ocelot, Parrot, or Wolf.

The spell does not function on tameable animals from other mods (such as Mo Creatures Extended).

Expected behaviour

I expected to be able to use Tame Animal on a Donkey/Horse/Llama/Mule while standing next to the animal with the Wand/Sage Tome/Spell Sword in hand (ie not a empty hand).

I also had expected Tame Animal to have a whitelist in config where I could add additional Neutral tameable animals from other mods such as: Mo Creatures Extended Ice and Fire

A Bauble to expand the tameable options might have a second whitelist in config, to allow additional mobs to be tamed.

Steps to reproduce

  1. Join a Server
  2. Move next to a Donkey/Horse/Llama/Mule
  3. Try to cast Tame Animal on the animal
  4. Move far away from the animal
  5. As you move closer, continue trying to cast the Tame Animal on the animal
  6. Notice how far away you need to be to be successful

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Issue present on both sides

Mod version

1.5.10

Forge version

1.12.2-forge-14.23.5.2860

Other mods

No response

WinDanesz commented 9 months ago

Have you tried sneak-casting the spell from close? RE: other mob mods.. If they implement IEntityTameable, I can add support for them, but this can get very OP depending on the mob. So I'm ok with extending support but only if it's balanced Some balancing ideas that could work in conjunction:

KnightCa commented 9 months ago

I did try to Sneak cast it while close.

On Sat, Dec 2, 2023 at 2:08 AM WinDanesz @.***> wrote:

Have you tried sneak-casting the spell from close?

— Reply to this email directly, view it on GitHub https://github.com/WinDanesz/AncientSpellcraft/issues/191#issuecomment-1837109830, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMMPUYI4FYFDXDIMFCCQOCTYHL4YBAVCNFSM6AAAAABADWMW32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGEYDSOBTGA . You are receiving this because you authored the thread.Message ID: @.***>

WinDanesz commented 9 months ago

Added some more details above.

KnightCa commented 9 months ago

I like the third option the most, as this allows the modpack creator to scale the spell up with potency and their desired inclusions.

Could we make Tame Animal a Novice spell to allow more potency spread? Novice (15) would do ocelot, parrot, and wolf. Apprentice (30) would include donkey, horse, llama, and mule.

I assume that float = the percentage of potency (wand 15/30/45/60, spell blade 5/10/15/20)

Examples of other mobs: Novice Wand mocreatures:fox:15 mocreatures:turtle:15 Apprentice Wand mocreatures:blackbear:30 mocreatures:pandabear:30 mocreatures:grizzlybear:30 iceandfire:hippocampus:30 Advanced Wand iceandfire:cockatrice:45 iceandfire:hippogryph:45 mocreatures:elephant:45 mocreatures:polarbear:45 Master Wand iceandfire:amphithere:60 iceandfire:pixie:60