WinDanesz / AncientSpellcraft

An extension mod for the Electroblob's Wizardry Minecraft 1.12.2 mod
https://www.curseforge.com/minecraft/mc-mods/ancient-spellcraft
GNU General Public License v3.0
7 stars 15 forks source link

[Bug] Curse of Death does not result in death #220

Closed KnightCa closed 11 months ago

KnightCa commented 11 months ago

Is there an existing issue for this?

Observed behaviour

I've been looking into Curse of Death. I used a Dispenser to curse myself, so that I could check to see if it still leaves no grave from Corail Tombstone. I saw the curse marker and eventually it counted down (3 days minecraft time), but then I did not die (yep in Survival).

Expected behaviour

I expected that Curse of Death would kill the player and result in a tombstone (if using Corail Tombstone) with the equipment carried at death.

Steps to reproduce

  1. Join a server
  2. Use a dispenser to apply Curse of Death to yourself.
  3. Wait 3 days to see the Curse timer run out.
  4. No death results.

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Issue present on both sides

Mod version

1.5.11-PreRelease-54bfadc

Forge version

1.12.2-forge-14.23.5.2860

Other mods

tombstone-4.6.2

KnightCa commented 11 months ago

@WinDanesz After putting the Curse of Death in the Dispenser and hitting myself with it, I get the below icon appear but with no count-down timer. I waited for several hours in Survival mode on Difficulty Easy to see if it would kill the player.. but so far nothing.

Does this look right?

image

WinDanesz commented 11 months ago

Don't wait hours, just use /effect yourplayername ancientspellcraft:curse_of_death 5

WinDanesz commented 11 months ago

If you want to test the effect. I'll check the timer

KnightCa commented 11 months ago

Giving the effect worked. I'd appreciate checking the timer for getting the effect, as it appears to be XX'd out.

On Thu, Jan 4, 2024 at 6:54 AM WinDanesz @.***> wrote:

If you want to test the effect. I'll check the timer

— Reply to this email directly, view it on GitHub https://github.com/WinDanesz/AncientSpellcraft/issues/220#issuecomment-1877226857, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMMPUYJYGLGD5FZS66XZHUDYM27BBAVCNFSM6AAAAABANRRX52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGIZDMOBVG4 . You are receiving this because you authored the thread.Message ID: @.***>

KnightCa commented 11 months ago

Confirmed that this is already working correctly in the new release. When the time period is too long, you get a XXX for the countdown until it reaches a low enough time period.