[Bug] Melee Upgrades do not benefit Spell Blades the way they do a Wand

[KnightCa]

Is there an existing issue for this?

• [X] I have searched the existing issues

Observed behaviour

Currently the Master Spell Blade gains far less benefit for Melee Wand upgrades than Wands do. Even with 3 Siphon upgrades, the Spell Blade will continually have its mana reduced.

Wand

• 3 Melee upgrades: damage increases from 1 to 7 = -12 mana/hit (4 mana/melee upgrade, 2 mana/1 damage increase)
• 3 Siphon Upgrades: on average regain the mana cost of 1 hit on each kill.

Master Spell Blade (base damage = 2, increase per tier = 1): base damage 6

• 3 Melee upgrades: damage increases from 6 to 9 = -18 mana/hit (6 mana/melee upgrade, 6 mana/1 damage increase)
• Master Wand Capacity: 2,500 mana (138 hits)
• Runic Shield Capacity: 1,000 mana (55 hits)
• 3 Siphon Upgrades: on average regain 2/3 of the mana cost of 1 hit on each kill.

3 Siphon Upgrades give 9-15 mana/kill to first mana item (priority: main hand, off-hand, left to right hotbar).

Expected behaviour

By looking at Wand Melee upgrade calculation, I expected that it should cost 2 mana/1 damage increase. If so, that would mean either of the following options. I find option 1 a better solution, since it would mean that 3 Siphon Upgrades and 3 Melee upgrades roughly balance one another (assuming that each hit of the blade kills a target).

Option 1: Master Spell Blade (base damage = 2, increase per tier = 1): base damage 6

• 3 Melee upgrades: damage increases from 6 to 12 = -12 mana/hit (4 mana/melee upgrade, 2 mana/1 damage increase)
• Master Wand Capacity: 2,500 mana (138 hits)
• Runic Shield Capacity: 1,000 mana (55 hits)
• 3 Siphon Upgrades: on average regain the mana cost of 1 hit on each kill.

Option 2: Master Spell Blade (base damage = 2, increase per tier = 1): base damage 6

• 3 Melee upgrades: damage increases from 6 to 9 = -6 mana/hit (2 mana/melee upgrade, 2 mana/1 damage increase)
• Master Wand Capacity: 2,500 mana (416 hits)
• Runic Shield Capacity: 1,000 mana (166 hits)
• 3 Siphon Upgrades: on average regain double the mana cost of 1 hit on each kill.

Steps to reproduce

1. Join a Server
2. Apply 3 Wand Melee Upgrades, 3 Siphon Upgrades, and a Wand Storage Upgrade to a Master Spell Blade
3. Kill mods and notice how long the mana lasts in the sword.

Environment (Singleplayer/Server, etc.)

Issue present on both sides

Mod version

1.5.11-PreRelease-4f214c5

Forge version

1.12.2-forge-14.23.5.2860

Other mods

No response

[WinDanesz]

Basic attacks doesnt consume mana if you have a runic shield

[WinDanesz]

At least thats how I expected them, did this change?

[KnightCa]

With the config set to default:

The amount of mana required & consumed when the spellblade is used to hit a target, based on the tier of the blade

# Example: if the cost is 5, a novice blade will consume 5 mana, an apprentice sword will consume 2x5 mana, a master blade will consume 20 mana
# Min: 1
# Max: 100
I:"Spellblade base hit mana cost per tier"=5

If using a Runic Shield with no upgrades, and Master Spell Blade:

1. Without any upgrades, then no mana is used in a basic attack
2. With 3 Melee upgrades, then no mana us used in a basic attack

Note that without a Runic Shield, then damage is half unless the Spell Blade has a Storage upgrade.

With or without a Runic Shield with no upgrades, a Master Spell Blade:

1. With a Storage upgrade (thus giving it 288 mana), then 20 mana is used in a basic attack (config)
2. With a Storage upgrade and 3 Melee upgrades, then 38 mana is used in a basic attack (20 config + 6/melee upgrade)

Thus, having a Storage upgrade on the Spell Blade (and thus mana present in the Blade), even when used with a Runic Shield.. ends up treating it as if there is no shield present and drains mana on a basic attack.

[WinDanesz]

9e66903a29dc955ebb05c889f178dd6408c1869d fixes swords consuming mana when a storage upgrade is added (and a shield is held)