WinDanesz / AncientSpellcraft

An extension mod for the Electroblob's Wizardry Minecraft 1.12.2 mod
https://www.curseforge.com/minecraft/mc-mods/ancient-spellcraft
GNU General Public License v3.0
7 stars 15 forks source link

[1.12.2] Regular Warlock Orbs seems to boost "None" Element Potency? #257

Closed SonicX8000 closed 5 months ago

SonicX8000 commented 7 months ago

Is there an existing issue for this?

Observed behaviour

Something I've noticed while messing around with the Warlock Orbs, mainly the Regular / Magic ones. It seems that they boost the Potency for the None Element, such as Magic Missile.

I checked the Elemental Warlock Orbs and they didn't boost the Potency for Magic Missile... though they do boost the matching element which... is intended. Here's a video showing the damage values.

I show the Magic Wands, the Magic Orbs and then comparing them with the Earth Orb (Any Elemental one can work)

Video:

https://github.com/WinDanesz/AncientSpellcraft/assets/36653806/29424e89-f680-49b9-8fa5-f81c79ac5a80

Expected behaviour

Regular Magic Warlock Orbs not boosting Potency. The base damage for Magic Missile with no buffs is 3 though depending on the Orb Tier for the Regular Orbs... you can hit...

Novice: 3.75 (+25%) Apprentice: 4.5 (+50%) Advanced: 5.25 (+75%) Master: 6 (+100%)

(ToroHUD shows this, though it rounds up the damage (Like if you hit 4.5, it'll show a 5))

Steps to reproduce

  1. Imbue a Regular Warlock Orb with Magic Missile.
  2. Cast the spell at a mob with decent health such as a Iron Golem, though any mob works.
  3. The mob will take slightly increased damage from the Orb.

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Singleplayer

Mod version

1.7.3

Forge version

1.12.2 - 14.23.5.2860

Other mods

!mixinbooter-9.1 Baubles-1.12-1.5.2 ElectroblobsWizardry-4.3.13 HadEnoughItems_1.12.2-4.25.4 torohud-1.12.2-5 WizardryUtils-1.12.2-1.2.2