WinDanesz / RiseOfTheAnimagus

https://www.curseforge.com/minecraft/mc-mods/rise-of-the-animagus
GNU General Public License v3.0
3 stars 1 forks source link

[Bug] Lich's Hunger has limited ways to refill it #30

Closed KnightCa closed 5 months ago

KnightCa commented 9 months ago

Is there an existing issue for this?

Observed behaviour

Currently, a lich's hunger needs to be filled by one of the following methods:

  1. Drinking from a hot-bar phylactery that has stored up a specific mobs deaths
  2. Killing mobs with a Necromancer Spell Blade with matching battlemage gear

The problem with the above is these:

  1. Since you need to keep the phylactery that stores the lich's soul in the charm slot, then you need two phylacteries to survive as a lich (the second one to drink from). In addition, this is a issue with modpacks with many types of mobs.. as the phylactery stores only one type.. forcing the lich to have to hunt that type to survive.
  2. Relying on a Necromancer Spell Blade rules out many other options (can't play another type of Battlemage or Sage or Warlock)

Expected behaviour

I would suggest that you allow any kills from a lich (melee or spell) to be able to replenish the hunger bar for the lich without the need for a phylactery to do so. This would mean a lich could hunt any type of mob to refill the hunger bar, rather than needing to seek a specific type.

This would mean tweaking the Necromancer Spell Blade to do something else cool (perhaps heal summoned minions on a kill with a charged blade).

If you wanted to make sure that lich's stayed motivated to hunt, you might:

  1. make a configurable setting for how fast their hunger bar depletes
  2. cause healing potions to no longer help the lich
  3. cause many healing spells (sigil of healing, healing hearts, etc) cause damage to lich's the way it does other undead

Steps to reproduce

  1. Join a Server with multiple mobs added
  2. Change to lich
  3. Do actions to reduce hunger
  4. Notice you need two phylacteries or a Necromancer Spell Blade to keep hunger filled
  5. Notice the effort involved in filling a phylactery from only one mob source

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Issue present on both sides

Mod version

1.1.0

Forge version

1.12.2-forge-14.23.5.2860

Other mods

AncientSpellcraft v1.6.3 ElectroblobsWizardry v4.3.12

KnightCa commented 8 months ago

Methods to recover a lich's hunger bar

Question: "The only way to recover the hunger bar seems to drink from a phylactery. Is there another way? (this suggests you need at least two phylacteries before becoming a lich.. one for the lich's soul, the other to collect kills with to replenish hunger)"

Dan's response: "I can address this by adding a low tier lich spell that drains targets for soul-hunger refill. Could also add an artefact that makes any kill directly refill some souls."

  1. I like the option of a low tier lich spell to drain targets for a soul-hunger refill.
  2. I also like the option of a artefact that makes any kill directly refill some souls. Can this artefact be used to cause kills to directly refill some of the hunger bar (rather than refilling the phylactery, which must then be drunk)?
  3. Is it possible to allow the same phylactery used to make the lich (storing the lich's soul) be useable in the hotbar (without causing negative effects to the lich while in hotbar) as the phylactery used to store kills that can be used to replenish hunger bar? That way, only a single phylactery is needed (rather than the current system which needs two).
  4. If not possible/desirable to do 3, can we have a extra empty phylactery be given to the character as part of the transformation into lich?

Phylactery only allows one soul type

Question: "The phylactery in the hot bar fills from the first type of entity killed. That means you have to continue killing the same type of entity to refill it, to drink from. Other mods killed do nothing to fill it. (seems challenging keeping it full to drink with if there is a large variety of mobs available)"

Dan's response: "Can't help with this. A phylactery only can hold one soul type. Best I can do is to make sure the lich can fully empty it and it resets to default blank state."

That would be great to allow the lich to fully empty it when drinking and resetting to default blank state (if emptied)? That would avoid two issues:

KnightCa commented 5 months ago

2024-05-22 - Dans Thoughts from Discord:

Options for liches to replenish hunger:

  1. Lichdrain spell: It deals better dmg than Life Drain and restores hunger. Leave phylactery on pyramid or in charm slot.
  2. Soul phylacteries in the hotbar with any mob souls
  3. Satiety spell and Replenish Hunger spell
    • May ban these for liches
  4. Necro battlemage sword effect
  5. Life Drain spell + Gravemir's Grimfeast Ring
KnightCa commented 5 months ago

Solved by having at least 5 methods to regain hunger. Suggested the generic soul container and ways to get lich spells easier in separate tickets.