WinDanesz / WizardryFates

A small addon mod for Electroblob's Wizardry (Minecraft 1.12.2) which forces players to specialize in one magical element.
GNU General Public License v3.0
3 stars 2 forks source link

[Bug] Config requirement to wear a full set of Wizard armor to be able to cast spells #37

Open KnightCa opened 6 months ago

KnightCa commented 6 months ago

Is there an existing issue for this?

Observed behaviour

Currently there are 3 config features that relate to wearing wizard armor that have been listed as Unused:

    # [UNUSED, upcoming feature] If true, players can only cast spells if they are wearing a full set of wizard robe.
    #  Needless to say, discipline enforcements still apply as well
    B:"Enforce Elemental Armour Set Wearing To Cast"=false

I believe that if this setting is set to true, then the caster must wear a full set of matching elemental armor to cast spells.

    # [UNUSED, upcoming feature] Only has an effect if 'Enforce Elemental Armour Set Wearing To Cast' is true.
    #  If true, players can only cast spells if they have a full set of MATCHING wizard armour which MATCHES WITH THE SPELL'S ELEMENT.
    #  Needless to say, discipline enforcements still apply as well
    B:"Enforce Discipline Armour Set"=false

I believe that if this setting is also set to true, then the caster must wear a full set of matching elemental armor to cast spells and the discipline of the spell must match the discipline of the armor (not sure how this effects spells that match the "None" element which may include Ancient spells and Chaos spells).

    # [UNUSED, upcoming feature] This only has an effect if 'Enforce Discipline Armour Set' and 'Enforce Discipline Armour Set' are BOTH true!
    #  If true, players can wear the generic (blue, "elementless") robes to cast stuff.
    #  Needless to say, discipline enforcements still apply as well
    B:"Allow Using The Generic Wizard Robe"=true

I believe that if all 3 settings are set to true, then the caster can either wear a full set of generic wizard robes or must wear a full set of matching elemental armor to cast spells and the discipline of the spell must match the discipline of the armor.

Expected behaviour

It would be nice to have these config options enabled and adjusted as follows:

    # If true, players can only cast spells if they are wearing a full set of wizard armour.
    # This can be a mix of the generic (blue, "elementless"), elemental armour, or class armour.
    # Example: Pyromancer Hat, "elementless" Wizard Robes, Healer Leggings, and Healer Warlock Boots
    B:"Require Wizard Armour Set"=true

    # Only has an effect if 'Require Wizard Armour Set' is true.
    # Players can only cast spells of this Tier or higher unless wearing a full set of wizard armour.
    # 0 - Novice
    # 1 - Apprentice
    # 2 - Advanced
    # 3 - Master
    # Min: 0
    # Max: 3
    B:"Require Wizard Armour Set : Tier"=0

    # Only has an effect if 'Require Wizard Armour Set' is true.
    # If true, players can only cast spells if they are wearing a full set of wizard armour of the SAME CLASS.
    # All armour must have the same class (including generic blue, battlemage, sage, or warlock).
    # Example: Sage Hat, Sage Robes, Sage Leggings, and Sage Boots
    B:"Require Matching Class Wizard Armour Set"=false

    # Only has an effect if 'Require Wizard Armour Set' is true.
    # If true, players can only cast spells if they are wearing a full set of wizard armour of the SAME ELEMENT.
    # All armour must have the same element (including "elementless").
    # Example: Healer Hat, Healer Robes, Healer Warlock Leggings, and Healer Sage Boots
    B:"Require Matching Element Wizard Armour Set"=false

    # Only has an effect if 'Require Wizard Armour Set' and "Require Matching Element Wizard Armour Set" are both set to true.
    # If true, players can only cast spells if they are wearing a full set of wizard armour of the SAME ELEMENT AS THE SPELL.
    # All armour must have the same element as the spell being cast.
    # Spells without a element (including 'None', 'Ancient', 'Chaos') are not affected by this setting.
    # Example: Casting a fire spell (Ignite) would be possible when wearing a Pyromancer Hat, Pyromancer Robes, Pyromancer Warlock Leggings, and Pyromancer Sage Boots
    B:"Require Matching Element Armour Set of the same Element as Spell"=false

Thus, the following configurations: "Require Wizard Armour Set"=true "Require Wizard Armour Set : Tier"=1 "Require Matching Class Wizard Armour Set"=false "Require Matching Element Wizard Armour Set"=true "Require Matching Element Armour Set of the same Element as Spell"=true

Would result in a player being able to cast Novice spells without wizard armor. If casting spells of Apprentice level or higher, the player would have to be wearing a full set of wizard armor of the same element (could be a mix of generic or class armor) in order to cast spells with that element (or with no element).

Steps to reproduce

  1. Join a Server after setting the wizard armor requirements to true
  2. Notice the lack of control of how the settings allow wizard armor requirements.

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Issue present on both sides

Mod version

2.2.1

Forge version

1.12.2 latest version

Other mods

No response