Closed GoogleCodeExporter closed 9 years ago
"4. File '/PATH/TO/hoge.avi' already exists. Overwrite ? [y/N] y"
do not choose to overwrite the file.
You should never use the same input and output paths for any program.
Original comment by bgg...@gmail.com
on 16 Feb 2011 at 4:53
The questions "no" and "yes" answer even if both the original file is lost.
I think this is a problem.
>4. File '/PATH/TO/hoge.avi' already exists. Overwrite ? [y/N] n
>5. Preview original video
>6. /PATH/TO/hoge.avi original video deleted. Unhappy.
The preview process, I think measures should be.
The questions "no" answer, but that with the original files are lost.
I think the preview file name appropriate to a temporary file name.
What do you think?
Original comment by tdms.m...@gmail.com
on 16 Feb 2011 at 5:12
just make the destination different
Original comment by bgg...@gmail.com
on 16 Feb 2011 at 5:41
Matt, no offence, but I think the OP is just asking us to protect him/her from
doing just that, choosing the same output folder as the input. In principle,
this check should not be very difficult.
If YOU don't want to accept this as a valid request, I might consider if I can
come up with something, although fpc is not yet my language.
Original comment by poipodec...@hotmail.com
on 16 Feb 2011 at 6:47
I fixed the preview process. I'm happy this fix.
# Thank you. This software has helped us very much.
Original comment by tdms.m...@gmail.com
on 16 Feb 2011 at 7:26
Attachments:
First, I agree, the preview file should really be a temporary file which can be
safely removed. I have an idea on how to achieve that and will report back with
that.
Further I have some progress on this bug to warn the user he is doing something
dangerous. Therefore I added the following to the TfrmMain.btnConvertClick
procedure, in the "build batch file" part. However, instead of showmessage, I
need a real window with the option to overrule the warning. The warning pops up
when I want it, but then I am lost how to do that.
// Test to prevent overwriting source files accidentely (ffmpeg Warns,
// but who cares about that). Fixes bug 110
if (ExpandFileName(destfolder.Text) = ExpandFileName(ExtractFileDir(filename)))
then
begin
showmessage('The source and destination directory are the same. Proceed with caution.') ;
script.Clear ;
break ;
end;
Original comment by poipodec...@hotmail.com
on 29 May 2011 at 7:10
Inspired by your patch I created the code I just committed to the svn version
of winff in revision 535. This solves the problem that the wrong file is
deleted when previewing.
Matt, I still could use some help with the warning as I mentioned in my
previous comment.
Original comment by poipodec...@hotmail.com
on 29 May 2011 at 8:18
I will look at here this week
Original comment by bgg...@gmail.com
on 7 Jun 2011 at 12:39
Original issue reported on code.google.com by
tdms.m...@gmail.com
on 16 Feb 2011 at 10:53