WinFF / winff

Automatically exported from code.google.com/p/winff
215 stars 48 forks source link

BUG: Can't launch x-terminal-emulator when lxterminal installed #70

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
If I select the profile and click convert button - nothing happens

If winff launching from terminal, I see in console:
Usage:
  lxterminal [Options...] - LXTerminal is a terminal emulator
...

winff launching x-terminal-emulator whith parameters: -e shell_script &
Why & ?

All works fine, if I replaced x-terminal-emulator with script:

#!/bin/sh
x-terminal-emulator $1 $2

Where parameter $3 is removed.

Original issue reported on code.google.com by zerkalica@gmail.com on 6 Apr 2010 at 9:37

GoogleCodeExporter commented 9 years ago
Confirmed.

This is a bug in lxterminal against Debian policy 11.8.3 [1]. Are you using 
Debian or
Ubuntu, I can file a proper bug against the package as I have done for more 
terminals
[2,3]? Please, as a workaround, specify a terminal which does not contain this 
bug in
the winff preferences.

I think the & is there to ensure that the terminal is closed on completion of 
the
script, but I am unsure on that point.

[1] http://www.debian.org/doc/debian-policy/ch-customized-programs.html#s11.8.3
[2] https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/367954
[3] https://bugs.launchpad.net/ubuntu/+source/terminator/+bug/366644

Original comment by poipodec...@hotmail.com on 8 Apr 2010 at 8:12

GoogleCodeExporter commented 9 years ago
I have a ubuntu lucid, lxterminal 0.1.7-0ubuntu1. This terminal supported -e 
switch.

When i run it from console, all works fine:
$x-terminal-emulator -e /home/nexor/.winff/ff100409195544.sh &

But, if it started from winff, i see:
Usage:
  lxterminal [Options...] - LXTerminal is a terminal emulator
...

seems like this problem:
x-terminal-emulator "-e" "/home/nexor/.winff/ff100409200259.sh" "&"

& - If a command is terminated by the control operator &, the shell executes the
command in the background in a subshell

http://hacktux.com/bash/ampersand
man bash

why & used when launching terminal emulator in separate window?
seems like winff bug

Original comment by zerkalica@gmail.com on 9 Apr 2010 at 4:18

GoogleCodeExporter commented 9 years ago
Sorry, but this terminal does NOT support -e switch as intended by Debian 
policy. The
-e switch should use the remainder of the line as command, not just the first 
next
string. For instance, try:
$ lxterminal -e ls -al

I get the same Usage: line you also see. So for sure lxterminal has a bug.

I agree with you that the & seems superfluous. If it is, removing it would solve
issues with non-compliant terminals.

@ Biggmatt: what was your reasoning to include the & at the end?

Original comment by poipodec...@hotmail.com on 9 Apr 2010 at 7:53

GoogleCodeExporter commented 9 years ago
In the mean time I filed a bug against lxterminal @ Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/lxterminal/+bug/559556

Original comment by poipodec...@hotmail.com on 9 Apr 2010 at 8:02

GoogleCodeExporter commented 9 years ago
i used it to start a seperate process, so the terminal process wasn't tied to 
winff's 
process, and winff could just be closed and let the terminal run

Original comment by bgg...@gmail.com on 11 Apr 2010 at 3:52

GoogleCodeExporter commented 9 years ago
This means it is still needed right. I expect it is also needed to keep winff
responsive during conversion?

So I guess we can mark this bug as wontfix.

By the way, lxterminal seems to have fixed the issue in a later release (see the
launchpad bugreport).

Original comment by poipodec...@hotmail.com on 11 Apr 2010 at 7:13

GoogleCodeExporter commented 9 years ago
I believe so

Original comment by bgg...@gmail.com on 13 Apr 2010 at 4:26