search

WinMerge / winmerge

WinMerge is an Open Source differencing and merging tool for Windows. WinMerge can compare both folders and files, presenting differences in a visual text format that is easy to understand and handle.
https://winmerge.org/
GNU General Public License v2.0
6.15k stars 784 forks source link

Move custom messages in a separate iss file #2247

Closed bovirus closed 4 months ago

bovirus commented 4 months ago

@sdottaka

I moved Inno Setup custom messuges (now english/italian - equal for all .iss installer files) in a separate file

WinMergeCustomMessages.iss

The it'eseasier for anyone add new language strings without touch main installer script.

And the changes are required in only one file. befroe these changes you have to apply the custom emssage strings for each .iss installer script.

sdottaka commented 4 months ago

Thank you!

bovirus commented 4 months ago

@sdottaka

Please add in this file

https://github.com/WinMerge/winmerge/blob/master/Translations/README.md

the info about how to translate custom messages for installer.

The current note about Installer translation can create misunderstanding. The installer are already multilanguage (use of .isl files) and require only activities by translator about custoim messages.

Now the custom emssges are in a separate file (out of main installer script) and translator can add other languages (now are only english anbd italian).

Thanks.

sdottaka commented 4 months ago

Regarding your PR, I got an error when compiling with InnoSetup. It seems you forgot to add double quotes. I found that the messages you moved to WinMergeCustomMessages.iss can also be moved to the .islu file, so 1a9f0fa moved the messages to those files. I also deleted messages that I felt didn't require customization.

bovirus commented 4 months ago

@sdottaka

True. Sorry for double quote error. It's very basic error ;-).

For me is not a good idea to modify original .isl file (coming form Inno Setup standard installation) adding custom messages that are specific for the project.

My idea is that .isl file should remain untocuhed and Custom Messages strings should be in a separate file (single file for all languages).

Then translator change just only custom message file and not complete language (.isl/.islu file).

sdottaka commented 4 months ago

For me is not a good idea to modify original .isl file (coming form Inno Setup standard installation) adding custom messages that are specific for the project.

I may have misunderstood your response, but Translations/WinMerge/*.isl stores messages used only by the WinMerge installer, not files that came from the Inno Setup standard installation.

My idea is that .isl file should remain untouched and Custom Messages strings should be in a separate file (single file for all languages).

I feel it is better for translators to work with just one file for the installer rather than two. Also, WinMerge supports 37 languages, but if 37 languages are stored in one file, translators will not be able to edit them at the same time.

bovirus commented 4 months ago

@sdottaka

Thanks for thr explanation. I agree with you.