search

WinRb / WinRM

Ruby library for Windows Remote Management
Apache License 2.0
412 stars 117 forks source link

[POC] Replace erubis with erubi #300

Closed jrafanie closed 5 years ago

jrafanie commented 5 years ago

I'm opening this pull request to see if this is something that would be ultimately accepted. It looks like people have been moving off of erubis because it's mostly unmaintained and more complicated.

This seems to have been influenced greatly by rails: https://github.com/rails/rails/pull/27757

We needed to implement the result method from erubis: https://www.rubydoc.info/gems/erubis/2.7.0/Erubis/RubyEvaluator#result-instance_method

I got the tests to pass but I have no idea if I covered everything.

jrafanie commented 5 years ago

@mwrock Sorry to ping you directly, but in case you just missed this PR, I'd like to hear your opinion on replacing erubis with erubi. It's a concern because even if we're not using erubis with rails, just having erubis loaded by another gem causes a rails deprecation when loading rails templating engines. It seems like a good idea to drop erubis for all the reasons mentioned in the rails PR listed above, copied here for convenience: https://github.com/rails/rails/pull/27757

djberg96 commented 5 years ago

👍

jrafanie commented 4 years ago

See also https://github.com/WinRb/winrm-elevated/pull/29 .... are there any other gems that use erubis?