search

WinRb / WinRM

Ruby library for Windows Remote Management
Apache License 2.0
412 stars 117 forks source link

Add a cert_store option #330

Closed ussu closed 2 months ago

ussu commented 3 years ago

Hi, It would be great to be able to use the gem with for instance an in-memory certificate instead of a file! This PR add the option to use a cert_store option where it is currently possible to specify a ca_trust_path (https://rubydoc.info/gems/httpclient/HTTPClient/SSLConfig) I would love to have your feedback on this, Best regards, Sulidi

fwininger commented 3 years ago

@mwrock can you accept this PR ? thanks

pcai commented 3 months ago

Is this still relevant to merge?

fwininger commented 3 months ago

@pcai yes, we still use this branch on production.

fwininger commented 2 months ago

@pcai can you merge this ? I'm sad this isn't in today's release.

pcai commented 2 months ago

I would've, if this had test coverage. Since it doesn't, I need to do a few manual checks for sanity.

Perhaps later this week I can take a look

fwininger commented 2 months ago

thanks