search

WinRb / WinRM

Ruby library for Windows Remote Management
Apache License 2.0
412 stars 117 forks source link

Adding user-agent option #337

Closed laxa closed 2 years ago

laxa commented 2 years ago

Fix the issue #336. It should be noted that there is a slight change regarding the User-Agent with this PR. Before the changement the User-Agent would have been:

User-Agent: Ruby WinRM Client (HTTPClient_LIB_VERSION, ruby VERSION (DATE_VERSION))

After this PR, the User-Agent would simply be: Ruby WinRM Client.

As I am nowhere near the skill of a ruby developer, let me know if my code can be improved (I have run the required tests).

mwrock commented 2 years ago

This looks good. Thanks!

laxa commented 2 years ago

Thanks for the merge. Do you have any idea when a new release would be made? I introduced this PR to use it in another project that depends on WinRM. Cheers,

laxa commented 1 year ago

Hello sir, I am wondering if that would be possible to make a release including this fix and to push it on the gem so other projects can use it. Cheers