search

WinRb / WinRM

Ruby library for Windows Remote Management
Apache License 2.0
412 stars 117 forks source link

user_agent opt doesn't do anything #344

Closed gmkbenjamin closed 3 months ago

gmkbenjamin commented 3 months ago

Tried setting user_agent option but it doesn't seem to do anything. Still getting the default 'Ruby WinRM Client (2.8.3, ruby 3.1.2 (2022-04-12))' useragent string.

pcai commented 3 months ago

The user_agent change hasn't been released on rubygems yet. Are you using winrm from master? If not, try something like this in your gemfile:

git_source(:github) { |repo| "https://github.com/#{repo}.git" }
gem 'winrm', github: 'WinRb/winrm'

I was recently added as a maintainer so I can try to cut a release next week. Please reopen if you can confirm the user-agent option isn't working on master.

gmkbenjamin commented 2 months ago

Hello, I can confirm that master works. Could you cut a release for rubygems please? I have projects depend on this. Thank you. :)

pcai commented 2 months ago

Apologies for the delay - slipped my mind. Will get a release out today

pcai commented 2 months ago

released as v2.3.7