Corrected issue with invalid NICs being returned.

WinRb / vagrant-windows

Other

444 stars 83 forks source link

Corrected issue with invalid NICs being returned. #184

Closed jlekie closed 10 years ago

jlekie commented 10 years ago

Found an issue with invalid network adapters being returned from the winrs_v3_get_adapters.ps1 script. The invalid adapters shared the same MAC addresses as valid adapters but their netconnectionid was Nil.

sneal commented 10 years ago

First of all, thanks for the PR.

Is it even valid to have two network adapters with the same MAC address? That seems like a box config problem.

jlekie commented 10 years ago

I think it's related to having VirtualBox installed on the guest machine (using a nested VM for handling SSH). Haven't confirmed this but I believe it might be caused by VirtualBox's host-only adapters.

sneal commented 10 years ago

This seems like it would be safe to pull in, but I'd rather not pull in unless its necessary. Thought?