search

WinRb / winrm-elevated

Runs PowerShell commands as elevated over Windows Remote Management (WinRM) via a scheduled task
Apache License 2.0
27 stars 17 forks source link

Name Powershell Script and Log Files Uniquely #6

Closed jerryk55 closed 8 years ago

jerryk55 commented 8 years ago

In order to allow winrm-elevated to run concurrently against the same Windows server, name the powershell script uploaded to the server using a randomly generated UUID.

In addition, the logfiles generated by the script will be named using the pid of the script's running process.

We will clean up the logfiles when the script is finished. Since the same script can be uploaded once and invoked multiple times it will be left intact.

The intent here is to deal with the issue described here: https://github.com/WinRb/winrm-elevated/issues/5

@mwrock @sneal if you could review and possibly merge when possible that would be great. Open for discussion of course. Thanks!

sneal commented 8 years ago

LGTM. I think we can cross the debugging bridge when we need. Perhaps we look for an environment variable, when set we skip the log deletion.

mwrock commented 8 years ago

:+1: yeaah I wouldn't worry about the debug scenario

mwrock commented 8 years ago

tests work on my machine.

jerryk55 commented 8 years ago

Thanks guys. Will this be 0.3.0?

mwrock commented 8 years ago

yup. released!