search

WinVector / seplyr

Improved Standard Evaluation Interfaces for Common Data Manipulation Tasks
https://winvector.github.io/seplyr/
Other
49 stars 12 forks source link

parse_quosure() was soft-deprecated in rlang 0.2.0 #3

Closed lionel- closed 6 years ago

lionel- commented 6 years ago

Please use parse_quo() instead.

JohnMount commented 6 years ago

Thanks, Lionel.

I think the parse_quosure() code went in in July of 2017 (rlang 0.1.1 era, bulk replacing parse_expr()). I'll see if I can bulk-replace it with parse_quo() and set an rlang version bound.

JohnMount commented 6 years ago

Actually is it parse_quos() or parse_quo()? The help on rlang 0.2.2 seems to suggest parse_quos(), and I would like to minimize the number of iterations of this run-around.

lionel- commented 6 years ago

parse_quo() and parse_expr() throw an error when there is more than one expression in the string (like "foo; bar"). The plural variants return a list of expressions instead (which might be longer than the input character vector).

JohnMount commented 6 years ago

I have the changes in. Is this blocking an rlang CRAN release, or is this something I can wait on?

lionel- commented 6 years ago

Thanks. No hurry, I'm going to wait one more release before deprecating for good. We're also trying out a new soft-deprecation strategy that should be a bit more verbose and make it easier to discover retired functions: Soft-deprecated functions will send a warning once per session when rlang is attached or when the function is called from the global env.

JohnMount commented 6 years ago

Okay, thank you for the heads-up. Please do inform me if I have any more soft-deprecated or wrong-choice functions. I'll clean up such ASAP.

lionel- commented 6 years ago

With the dev version of rlang you can also set options(lifecycle_force_verbose_retirement = TRUE) and then run your tests to find out. This option forces the warnings.