search

WinVector / seplyr

Improved Standard Evaluation Interfaces for Common Data Manipulation Tasks
https://winvector.github.io/seplyr/
Other
49 stars 12 forks source link

dplyr::row_number() #5

Closed romainfrancois closed 4 years ago

romainfrancois commented 4 years ago

Starting from dplyr 1.0.0, row_number() won't be magic, so packages have to specify where it's from.

JohnMount commented 4 years ago

Thank you for the pull requests. I'll put this on the TODO list. I have some other projects due, so I can't work on this at this time.

Also I am not certain tests have been run on this pull request as no such claim was made, and an unqualified row_number() use also appears in the tests, so should have triggered a failure if run. To merge this I'll have to test on multiple versions of dplyr, which will take some time.

romainfrancois commented 4 years ago

The tests load dplyr, this code doesn't.

JohnMount commented 4 years ago

Ah, sorry about that you are right. I now see I did that explicitly in the test. Thank you for the correction.

That was a bad practice on my part that I didn't remember doing. I will have to fix that also.

JohnMount commented 4 years ago

Thank you for the pull request, now merged.