search

WinWorldPC / adventure

WinWorld's open library management system
GNU Affero General Public License v3.0
238 stars 33 forks source link

Use search icon (magnifying glass) glyph on search button #20

Open ghost opened 7 years ago

ghost commented 7 years ago

The search field's placeholder text already says 'Search'; there is no need for redundancy. It would make more sense to have the search button have an icon glyph of the magnifying glass (similar to Google's).

ghost commented 7 years ago

Implementation details: use <span class="glyphicon glyphicon-search"></span> in the search button. (Unless you're using Bootstrap v4, in which case the glyphicon font was removed. Consider using font-awesome.)

lpraz commented 7 years ago

The project appears to be using Bootstrap 4.0.0-beta, so glyphicons are ruled out. If we were to go the font-awesome route, would we just use their own CDN to get the icons (which requires a sign-in and an email address)? Google material icons could also be used, but which would be better? Also, would we use more glyphs out of either font?