tree includes source code for SHOUTcast DNAS

nilsding commented 3 hours ago

Hi, in /Src/Plugins/DSP/sc_serv3 is the source code of the SHOUTcast server software, which... I guess nowadays requires a user or subscription to just even receive the binaries? Not sure if this is supposed to be included here, but now its source code is just out there for all eternity...

Out of curiosity I built it on my main Linux machine that's running aarch64... had to adapt the GNUmakefile for that. Since forking is forbidden, I will just paste the diff here:

commit 80659e1cbd497e65a7df610e119fbb7aa757e44f (HEAD -> community)
Author: Jyrki Gadinger <nilsding@nilsding.org>
Date:   Tue Sep 24 18:37:22 2024 +0200

    sc_serv3: add support for building on aarch64 linux

diff --git a/Src/Plugins/DSP/sc_serv3/GNUmakefile b/Src/Plugins/DSP/sc_serv3/GNUmakefile
index eebf3052..9cfb5028 100644
--- a/Src/Plugins/DSP/sc_serv3/GNUmakefile
+++ b/Src/Plugins/DSP/sc_serv3/GNUmakefile
@@ -8,6 +8,7 @@ x64 := $(shell uname -m)
 ENDIAN := $(shell uname -m)
 ENDIAN := $(patsubst i%86,LITTLE_ENDIAN,$(ENDIAN))
 ENDIAN := $(patsubst x86_64,LITTLE_ENDIAN,$(ENDIAN))
+ENDIAN := $(patsubst aarch64,LITTLE_ENDIAN,$(ENDIAN))
 ENDIAN := $(patsubst Power Macintosh,BIG_ENDIAN,$(ENDIAN))
 CXX=g++ -std=c++11 -Wno-deprecated

@@ -61,7 +62,7 @@ ifeq ($(OS),LINUX)

                ### Linux platform specific includes
                ### with 32-bit and 64-bit handling
-               ifeq ($(x64),x86_64)
+               ifeq ($(x64),$(filter $(x64),x86_64 aarch64))
                        INCLUDES=-Ideps/x86_64/include
                        PLATFORM_LIBS=\
                                -Ldeps/x86_64/lib -lexpat -lcurl -lssl -lcrypto -lpthread -lz -lrt -ldl

And well, building it worked, and running the server software worked too:

Screenshot_20240924_183106

jfmauguit commented 3 hours ago

Code removed, thanks for the report

Architector4 commented 3 hours ago

/Src/Plugins/DSP/sc_serv3

HAHAHAHHHAAA AMAZING JOB

nilsding commented 3 hours ago

@jfmauguit unfortunately, this is not how Git works.

You would need to rewrite the commit history and remove that directory from the commit that added it (e.g. via git rebase --interactive) from all the branches. Right now people can simply revert the code-deletion commit using something like git revert 0a4b7d32d090696e5aab8de9c61dda9dab76aabf.

GitHub has a guide about this, though I haven't tried the mentioned tools there: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/removing-sensitive-data-from-a-repository

Architector4 commented 3 hours ago

Anyway now that the branch main was merged into community, undoing the commit that removed all this code from the branch, the codebase is back to having to the aforementioned proprietary code.

Reopen issue?

Architector4 commented 3 hours ago

Aw, ruined by Jef. Nevermind. The code is back to being publicly accessible through repo history.

https://github.com/WinampDesktop/winamp/commit/1be04037cdba95396eef7728134043ba3ee6fbf4