search

WinampDesktop / winamp

Iconic media player
https://winamp.com
Other
887 stars 222 forks source link

Fix licensing problems and remove proprietary code #18

Open llunacb opened 2 hours ago

llunacb commented 2 hours ago

hi , jeff.

I noticed tht the repository still had some proprietary code laying around that I dont think is allowed to be there. I also noticed that there were some problems with the license that makes it impossible for friends to contribute through github. I have fixed both of those problems in this PR.

I think I ahve executed this task in the optimal manner but feel free to tell me if I have made any mistakes and I will correct them.

Thans, luna!

Yotsubal commented 2 hours ago

LGTM

Yotsubal commented 2 hours ago

What a joke:

{3637CD12-4F0B-4906-9F2D-E2D00A56D7F2}
AJPfleger commented 1 hour ago

Would it make sense to split this PR in 2? Maybe first doing a clean removal and then fixing the license? I would not feel comfortable adding 60k new lines that fix a license (or "fix a license") hiding within 1kk changed lines.

Architector4 commented 1 hour ago

Would it make sense to split this PR in 2? Maybe first doing a clean removal and then fixing the license? I would not feel comfortable adding 60k new lines that fix a license (or "fix a license") hiding within 1kk changed lines.

Sounds like a good plan. Just have to make sure the fixed code still includes linuxdoom, of course.

thecaralice commented 49 minutes ago

Shouldn't have forked I guess, that's why your PR got closed /hj