search

WinampDesktop / winamp

Iconic media player
https://winamp.com
Other
895 stars 224 forks source link

Cant Wait for Lawsuit from Dolby #19

Open Yotsubal opened 2 hours ago

Yotsubal commented 2 hours ago

This software is company confidential information and the property of Dolby Sweden AB, and can not be reproduced or disclosed in any form without written authorization of Dolby Sweden AB. 


 This program is protected under international copyright laws as an
 unpublished work. Do not copy.

               (C) Copyright Coding Technologies (2004 - 2007)
                 (C) Copyright Dolby Sweden AB (2008 - 2009)
                             All Rights Reserved

 This software is company confidential information and the property of
 Dolby Sweden AB, and can not be reproduced or disclosed in any form
 without written authorization of Dolby Sweden AB.

 Those intending to use this software module for other purposes are advised
 that this infringe existing or pending patents. Dolby Sweden AB has no
 liability for use of this software module or derivatives thereof in any
 implementation. Copyright is not released for any means. Dolby Sweden AB
 retains full right to use the code for its own purpose, assign or sell the
 code to a third party and to inhibit any user or third party from using the
 code. This copyright notice must be included in all copies or derivative
 works.
ZaDarkSide commented 2 hours ago

It's fixed Jef deleted it also, don't worry everything is fine.

jprjr commented 2 hours ago

See also https://github.com/WinampDesktop/winamp/issues/17#issuecomment-2371984811 for a brief write-up on header files and copyright.

jfmauguit commented 2 hours ago

I agree with you @jprjr but I'll wait for the team to come back to me, I'll re-add this piece of code if it's OK

Yotsubal commented 1 hour ago

I agree with you @jprjr but I'll wait for the team to come back to me, I'll re-add this piece of code if it's OK

I think you should close the repo and check everything else first if it's OK to share the third-party code before publishing the entire source code online, so this one will not happen again https://github.com/WinampDesktop/winamp/issues/11

I mean github has history for deleted codes, and everyone can check the history

please correct me if I am wrong

ZaDarkSide commented 1 hour ago

I agree with you @jprjr but I'll wait for the team to come back to me, I'll re-add this piece of code if it's OK

I think you should close the repo and check everything else first if it's OK to share the third-party code before publishing the entire source code online, so this one will not happen again #11

I mean github has history for deleted codes, and everyone can check the history

please correct me if I am wrong

@Yotsubal it's fine, don't worry about it, let Jef work with his team he will get back to you on that. Cat is out of the bag anyway, no point to try to put it back in.

ZaDarkSide commented 1 hour ago

I also believe this is a duplicate issue and can be closed.

jprjr commented 1 hour ago

I agree with you @jprjr but I'll wait for the team to come back to me, I'll re-add this piece of code if it's OK

I think you should close the repo and check everything else first if it's OK to share the third-party code before publishing the entire source code online, so this one will not happen again #11

I mean github has history for deleted codes, and everyone can check the history

please correct me if I am wrong

Just a minor point - it is possible to rewrite git history and completely scrub things. The fact that I can reference commits like 0ee0230 and 1be0403 mean they're not scrubbed.

Unless GitHub gets involved though - that rewritten history won't apply to forks. In fact - I'm pretty confident that 1be0403 is not in this repo but GitHub helpfully lets me know that it exists somewhere.

And of course you can't account for anybody that's cloned the repo locally.

Once you push any commits to an internet-hosted repo, you kind of have to assume everybody has a copy now, even if you scrub it entirely from the git history.

EDIT: added example commit hashes to demonstrate they're not truly scrubbed

TempAccountNull commented 40 minutes ago

Regardless if you uploaded confidential information, you're still going to get sued. Because, even IF you deleted it from the repository.. You broke your agreement with the company and let the information become public.

I.E, It's in public space now.

YIKES.

ZaDarkSide commented 32 minutes ago

Regardless if you uploaded confidential information, you're still going to get sued. Because, even IF you deleted it from the repository.. You broke your agreement with the company and let the information become public.

I.E, It's in public space now.

YIKES.

Only if they really really care, which they don't, also they were just some header files, and they got deleted anyway.