search

Wind4 / vlmcsd

KMS Emulator in C (currently runs on Linux including Android, FreeBSD, Solaris, Minix, Mac OS, iOS, Windows with or without Cygwin)
https://forums.mydigitallife.net/threads/50234
8.35k stars 2.22k forks source link

docs: fix simple typo, routeable -> routable #47

Closed timgates42 closed 3 years ago

timgates42 commented 3 years ago

There is a small typo in src/msrpc-server.c, src/network.c.

Should read routable rather than routeable.

rouben commented 3 years ago

Thanks for the patch, @timgates42. Unfortunately, this is merely a mirror of the original project, which is distributed through this post on the MDL forums (note: registration is required for access). I've made attempts to convince the author of this software to publish this project and be more open to accepting patches such as yours through GitHub or a similar platform, however, I received quite a bit of pushback.

Long story short, merging this patch would mean that we will be deviating from upstream, which AFAIK, is a private SubVersion (or maybe nowadays it's git or hg?) repository used exclusively by the author.

I'll leave it up to @Wind4, the owner of this project to decide if this is the direction we want to take this project in. If the community wants to maintain a fork with community improvements, it means that someone from the community would then have to backport the patches from the fork to the upstream when the original developer of this project releases updates. These releases don't happen very often (usually once a year), but regardless of the release schedule, backporting will be an ongoing issue unless the upstream author chooses to be more openly collaborative.