search

Wind4 / vlmcsd

KMS Emulator in C (currently runs on Linux including Android, FreeBSD, Solaris, Minix, Mac OS, iOS, Windows with or without Cygwin)
https://forums.mydigitallife.net/threads/50234
8.35k stars 2.23k forks source link

Number of jobs should not be set in Makefile #64

Open Topkek-190 opened 2 years ago

Topkek-190 commented 2 years ago

The value of N in -jN depends on many factors and the decision should be ultimately left up to the user

Topkek-190 commented 2 years ago

cc: @rouben

rouben commented 2 years ago

The issue with this PR is that it will be difficult to maintain once a new release is available upstream. Remember, this repo is based on the contents of 7Zip/ZIP archives released upstream by the original author, who maintains their own private SubVersion repo for development.

Any ideas on how we can prevent this change from getting squashed with future releases?

Topkek-190 commented 2 years ago

Manually merging the Makefile, maybe? Or maybe a patch could be sent to the author(probably the only viable approach). Has any progress been made on the licensing issue?

Topkek-190 commented 2 years ago

@rouben I think, since the software hasn't been updated since 2020, it's probably better to make a tag for the current HEAD and then apply some fixes so that if a new version is released on the MDL website then the repo can be updated easily by making a branch at the original head, i.e. the tag.