WindChimeRan / pytorch_multi_head_selection_re

BERT + reproduce "Joint entity recognition and relation extraction as a multi-head selection problem" for Chinese and English IE
138 stars 32 forks source link

Bert model, and '11' #9

Closed antgr closed 4 years ago

antgr commented 4 years ago

In this line you search for the string 11. What does that mean, could you clarify? Thank you! https://github.com/WindChimeRan/pytorch_multi_head_selection_re/blob/30c8aa1b2d89a115612d2c5f344e96ab132220c8/lib/models/selection.py#L60

antgr commented 4 years ago

OK, means # only update last layer Could you consider create a function like that:

def isBertsLastLayer:
   return '11' in name
WindChimeRan commented 4 years ago

Sorry for my ugly code. PR welcomes.

antgr commented 4 years ago

No, your code is very good. I will make a PR, if you want that change.