search

WindSekirun / NaraeImagePicker

MultiImagePicker for Android Application, written in Kotlin
Apache License 2.0
40 stars 14 forks source link

Show selected image count in the FileView #12

Closed deepakkumardk closed 5 years ago

deepakkumardk commented 5 years ago

Is there any way to show the selected image count in the toolbar for FileView?

WindSekirun commented 5 years ago

No, but i can implement your issue.

In present, FileView only show '$pickerTitle'. Is ok for displaying '$pickerTitle ($pictureCount) in title of Toolbar?

deepakkumardk commented 5 years ago

Ya, that's work great. Thanks, for replying.

deepakkumardk commented 5 years ago

And please also update the targetSdkVersion, kotlinVersion, gradle and Glide to latest.

WindSekirun commented 5 years ago

There are currently several problems overlapping, so I want to fix other problems as well. The planning schedule is 15 May 2019 15:00 (UTC). If any issue is came out, leave out as new issue

WindSekirun commented 5 years ago

One more thing, are you using AndroidX? @deepakkumardk

deepakkumardk commented 5 years ago

No, currently not.

On Mon, 13 May 2019, 19:29 WindSekirun (DongGil, Seo), < notifications@github.com> wrote:

One more thing, are you using AndroidX?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WindSekirun/NaraeImagePicker/issues/12?email_source=notifications&email_token=AKMBX562CTIQZWCTHKHO5YTPVFX43A5CNFSM4HMPVQB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVIMXGA#issuecomment-491834264, or mute the thread https://github.com/notifications/unsubscribe-auth/AKMBX53DWS423F5XVSD4FLDPVFX43ANCNFSM4HMPVQBQ .

deepakkumardk commented 5 years ago

Hi @WindSekirun I have made a PR, please have a look at that.

deepakkumardk commented 5 years ago

Hi @WindSekirun item.uiSetting.pickerTitle is not working even after calling sendEvent() in library?? Have any idea?

WindSekirun commented 5 years ago

@deepakkumardk after apply PR that you made? I'll check.

WindSekirun commented 5 years ago

Solved in 2.0.0. Thanks!