search

WindSekirun / NaraeImagePicker

MultiImagePicker for Android Application, written in Kotlin
Apache License 2.0
40 stars 14 forks source link

Add select image count for both file view and folder view #14

Closed deepakkumardk closed 5 years ago

deepakkumardk commented 5 years ago

Added the selected image count and also add a listener for image click

WindSekirun commented 5 years ago

I have identified the following:

  1. Library has apply 'uiSetting.pcikerTitle' in BaseFragment.onViewCreated L43
  2. You just send ToolbarEvent by sendEvent(ToolbarEvent("$selectCount Selected", true)) in AllFragment.onImageClick. So, after click of item, pickerTitle will not show anymore.

So, i suggest sending this event. Before: sendEvent(ToolbarEvent("$selectCount Selected", true)) After: sendEvent(ToolbarEvent("${PickerSet.getSettingItem().uiSetting.pickerTitle} ($selectCount)", true))

Of course, you need to change selectCount to SelectedItem.getSize i recommended.

If this is not the case, I think i'll need a little more explanation on the issue you've raised. : 'item.uiSetting.pickerTitle is not working even after calling sendEvent() in library??'

Edit: Check out #15 for this problem.

deepakkumardk commented 5 years ago

I wasn't talking about the sendEvent onImageClick, the toolbar title remains as the appName for the initial value, rest is working fine.

WindSekirun commented 5 years ago

It seems to be a bug that existed in the past. Checked in FolderView and FileView.

This issue seems to be a separate issue.

WindSekirun commented 5 years ago

Check out #15 for 'item.uiSetting.pickerTitle is not working even after calling sendEvent() in library??'.

After review is completed, I'll merge #14 and #16 together.

WindSekirun commented 5 years ago

i plan to release it soon, so i will merge it into the dev/2.0 branch, not the master.