Fix maintain state of fragment while selecting images

WindSekirun / NaraeImagePicker

MultiImagePicker for Android Application, written in Kotlin

Apache License 2.0

40 stars 14 forks source link

Fix maintain state of fragment while selecting images #20

Closed deepakkumardk closed 4 years ago

deepakkumardk commented 4 years ago

Fix maintain the state of fragment onconfig changes
Fix flicker while show/hide in ImageDetailsActivity

To fix the flicker I used toolbar wrapped in card view (To handle the click listener for back button) with elevation. I don't know it's the best way or not but in this way we can provide the back compatibility without using the android:elevation attribute.

WindSekirun commented 4 years ago

I don't understand why flicker related with toolbar? I can imagine flicker means image flicking in PhotoView.

Before reviewing / merging this, Can you give me some points to explain the situation?

deepakkumardk commented 4 years ago

I mean when user tap on the photoView then we are showing & hiding the toolbar and that's where flickering occurs. I think in-build show/hide method for supportActionBar are causing this. You can view this video https://drive.google.com/file/d/18h6IOtJ-JVXHDAK57slZBDsBJU8mHjgJ/view?usp=sharing

deepakkumardk commented 4 years ago

Made the commit as suggested.

WindSekirun commented 4 years ago

Deploy as 2.0.6 . 🙇