search

WindSekirun / RollingBanner

Infinity RollingBanner with few code
Apache License 2.0
9 stars 7 forks source link

Page indicator #2

Open IRMobydick opened 6 years ago

IRMobydick commented 6 years ago

Hi there, What happened if banner pages count be so big? for example more than 30! How indicator act with this issue? Can handle it like Instagram app?

WindSekirun commented 6 years ago

I guess indicator may not working properly.

Unfortunately, I don't have instagram account and I don't have many time to solve this issue.

Can you provide some idea(or PR)?

Indicator has implemented by Imageview and LinearLayout. when user called 'notifyDataSetChanged()', ImageView will add into LinearLayout without scrolling.

The situation with many pages is not considered.

WindSekirun commented 6 years ago

Perhaps it is an issue to look at in the long term. let me think.

IRMobydick commented 6 years ago

I think the solution is there: https://github.com/rbro112/Android-Indefinite-Pager-Indicator

WindSekirun commented 6 years ago

okay, i will check.