search

WindSekirun / RxSocialLogin

An Android Library that provides social login for 15 platforms within by RxJava2, Kotlin and Firebase Authentication.
Apache License 2.0
125 stars 19 forks source link

🐛 KakaoLogin has only one sessionCallback #60

Closed greedy0110 closed 3 years ago

greedy0110 commented 3 years ago

Problem

KakaoLogin.login: create new sessionCallback instance and add sessionCallback using addCallback

And It doesn't clear. So, multiple callbacks are registered in same time.

ChangeLog

KakaoLogin.login()'s logic is changed.

As-is

  1. create new sessionCallback instance
  2. add callback

To-be

  1. if it already has sessionCallback instance, then removeCallback
  2. create new sessionCallback instance
  3. add callback
WindSekirun commented 3 years ago

Released in 1.2.6-androidx, Thanks for contribution