Winded / RagdollMover

A tool for Garry's Mod to make ragdoll posing easier.
6 stars 4 forks source link

Misaligned Gizmos/Movement Arrows #27

Closed ToxicHolyGrenade closed 9 months ago

ToxicHolyGrenade commented 11 months ago

Another problem is that through some reason when saving the game and going back to working on the ragdolls, the gizmos/movement arrows will be out of sync, and also misaligned (i.e. the arrows not pointing in the right directions, like instead of being straight in line, the arrows point in different angles, which should not be happening).

There are two theories on why this occurs. Either A), it happens with all Gmod saves, which is something that can be concerning for not just Gmod artists, but also Gmod animators. B), is with the ragdoll duplicates.

Can this be classified as a "will-not-fix" kind of issue, or can this be patched out?

(For the record, I am getting this problem more recognition as possible, because I do emphasize that this is a problem that has persisted for goodness knows how long.)

penolakushari commented 11 months ago

I've never had this issue with current wip ragdoll mover or the workshop one. As I did ask on steam, did you happen to disable all your addons except for ragdoll mover and check with that?

ToxicHolyGrenade commented 11 months ago

@penolakushari From what I had seen before, nothing is coming up on my Garry's Mod error notices that there are conflicting addons regarding Ragdoll Mover.

penolakushari commented 11 months ago

Still do a run without any other addons enabled just to be sure

ToxicHolyGrenade commented 10 months ago

Still do a run without any other addons enabled just to be sure

Okay, I tried to recreate the same problem but with the rest of the addons being disabled, and sadly, the end result is the same. So it has nothing to do with conflicting addons.

ToxicHolyGrenade commented 10 months ago

@penolakushari I decided to dig in further on how to reproduce this bug in-game, and as it turns out, the problem is with the duplicated ragdolls needing to be faced in a specific direction from where the player faces when entering a level.

So if the duplicated ragdolls are spawned from a different angle, that causes the gizmos and such, to be misaligned. I have NEVER seen anything like this before.

ToxicHolyGrenade commented 10 months ago

@penolakushari But on top of that, the rotational gizmos become misaligned even if the precise angle is correct. It blows my mind.

ToxicHolyGrenade commented 10 months ago

hl2 2024-01-15 19-01-26-55 hl2 2024-01-15 19-01-38-43 hl2 2024-01-15 19-01-47-85

ToxicHolyGrenade commented 10 months ago

@penolakushari The other question is, would it be wise to start over and recreate the addon, so long as the source code isn't thrown completely out? Simply fix the coding? Create and implement a feature for Ragdoll Mover users to correct/auto-correct the gizmos of spawned duplicates? Or can we use ChatGPT to overhaul the source code?

penolakushari commented 10 months ago

Where's the problem? There's none, as the gizmos seem to be in the localized mode, and position and angle ones use separate localized toggles, and those use angles of the currently selected bone, so "local" to it. Therefore it is more of a thing with the ragdoll you're using having pelvis bone angled like that. To have stuff local to "world coordinates" disable these checkboxes at the top of the tool's C menu. image Please do not suggest using chatgpt, I can't really access it anyway and the current update seems to be shaping up well without it.

ToxicHolyGrenade commented 10 months ago

Localized? angles and positions? My bad. I'll try this out again, and I will keep you noted if there are other problems.

ToxicHolyGrenade commented 10 months ago

Where's the problem? There's none, as the gizmos seem to be in the localized mode, and position and angle ones use separate localized toggles, and those use angles of the currently selected bone, so "local" to it. Therefore it is more of a thing with the ragdoll you're using having pelvis bone angled like that. To have stuff local to "world coordinates" disable these checkboxes at the top of the tool's C menu. image Please do not suggest using chatgpt, I can't really access it anyway and the current update seems to be shaping up well without it.

Bad news, I unchecked the localized gizmo options, and I am still getting those misaligned issues. My theory is that somehow, depending on white height or angle I have saved the duplicated ragdolls, results in the gizmos being positioned wrongly. It is mainly the duplications we are talking about.

hl2 2024-01-18 20-04-58-98

hl2 2024-01-18 20-05-19-40

ToxicHolyGrenade commented 10 months ago

@penolakushari The other theoretical cause, is the stand tool/feature. IF the previous issues I have noted aren't what's causing this, perhaps make the ragdoll mover tool more compatible with the stand tool, if that's anything to go by.

penolakushari commented 10 months ago

What you are showing is the gizmos in the world angles mode, so it's working as intended. If you want them to assume angles of your currently selected bone, then enable that stuff back up. If you want to speed up the thing with some binds, you can use some "bind toggle" stuff with ragmover_localang and ragmover_localpos which use 0 or 1 as arguments

ToxicHolyGrenade commented 10 months ago

What you are showing is the gizmos in the world angles mode, so it's working as intended. If you want them to assume angles of your currently selected bone, then enable that stuff back up. If you want to speed up the thing with some binds, you can use some "bind toggle" stuff with ragmover_localang and ragmover_localpos which use 0 or 1 as arguments

Okay, as much as I don’t want to be blunt, but why the heck would you manufacture a feature like this if it is going to bring more hardships than benefits? If anything, world mode should rather be left out of it, or at the very least, have it kept in a more advanced variation of the same tool.

Because while there is no question there may be features that will provide more usefulness, the world mode, from the way its designed, hardly brings anything useful to the table. I’m sorry to break your dream, but that’s the reality of why some, if not all, features can be abusive and unfriendly to the user to the point things will become like a hassle fest. Useful features would be like ones that provide more efficiency, and make things easier. The likes of world mode, has none of that.

penolakushari commented 10 months ago

I'm afraid that the only one who makes stuff harder here is you. World/Localized gizmo transforms feature was present in ragdoll mover since it was made by Winded way back with more simpler functionality of mostly moving physics stuff, before I've added all the bells and whistles for manipulating nonphysical bones or effect prop stuff. Whole thing can be just enabled through the localized gizmos check and due to how console variables work, it'll remember the setting between your play sessions, so you may just as well forget about it after enabling, if it's that much of a bother.

ToxicHolyGrenade commented 10 months ago

You may have a valid point, but the problem is, the I am not that convinced, because even after I have disabled the Ragdoll Mover Localized gizmos, the gizmos are still misaligned with the duplicated ragdolls, which makes no sense in a bad way. Despite the evidence I gave, you guys do not believe me. I literally disabled the check boxes off, and it still happened. Recently today, I checked the boxes on and off, still results in the same outcome. If anything, if its not the fault of the tool, then it is the fault of the Garry's Mod duplication system, if that's anything to go by.

penolakushari commented 10 months ago

The duped thing is still the ragdoll, it's not some animated entity that breaks everything once it gets duped? Perhaps you could upload it to steam workshop as a usual dupe so I may just as well check it on my end, steam and all.

ToxicHolyGrenade commented 10 months ago

The duped thing is still the ragdoll, it's not some animated entity that breaks everything once it gets duped? Perhaps you could upload it to steam workshop as a usual dupe so I may just as well check it on my end, steam and all.

No, not really, because from what I remembered, I never converted the ragdoll into an animation entity at the time I was reworking on Counteractor's appearance. Plus, I also recently did Neo, who is a Spy TF2 Freak, and I saved him to my workshop dupes.

Neo: https://steamcommunity.com/sharedfiles/filedetails/?id=3144270436

Required Addons

https://steamcommunity.com/sharedfiles/filedetails/?id=135491961

https://steamcommunity.com/sharedfiles/filedetails/?id=514736326

Windy Sally Parker/Counteractor: https://steamcommunity.com/sharedfiles/filedetails/?id=2949350786 & https://steamcommunity.com/sharedfiles/filedetails/?id=2949662824

Required Addons

https://steamcommunity.com/sharedfiles/filedetails/?id=2891075442

https://steamcommunity.com/sharedfiles/filedetails/?id=312899896

https://steamcommunity.com/sharedfiles/filedetails/?id=405793043

ToxicHolyGrenade commented 10 months ago

Actually, sorry, scratch that, its not just the duplications of ragdolls, it also occurs with ragdolls that are positioned with the Stand Tool. I tried that recently just now. All you have to do, is go on Gmod, spawn a ragdoll, use the stand tool and position the ragdoll in a particular angle, use the ragdoll mover, and see if the problem gets reproduced.

penolakushari commented 10 months ago

Nope, couldn't reproduce the issue you are describing. Could you try to record a video of how you turn on and off the options whereas having some bone on the ragdoll selected? It switching orientations should be visible there, as well as you did say that such an issue persists even with all other addons off.

ToxicHolyGrenade commented 10 months ago

Nope, couldn't reproduce the issue you are describing. Could you try to record a video of how you turn on and off the options whereas having some bone on the ragdoll selected? It switching orientations should be visible there, as well as you did say that such an issue persists even with all other addons off.

Are you referring to the comment I had posted about my duplications, or are you referring to the one mentioning the stand tool as of now?

penolakushari commented 10 months ago

Happened to go through and dupe, and stand pose stuff, all gizmo angles work as intended in any case. Having some possibility to see what happens on your end would give some insight I'd say.

ToxicHolyGrenade commented 10 months ago

As for recording a video, I tried, but the file size is too big unless I optimize it.

penolakushari commented 10 months ago

You could upload it to youtube I guess, it generally translates it into its own format that handles the rest. May take a while though

ToxicHolyGrenade commented 10 months ago

hl2 2024-01-23 19-00-38-56 hl2 2024-01-23 19-01-03-00 hl2 2024-01-23 19-01-09-56 hl2 2024-01-23 19-01-13-02 hl2 2024-01-23 19-01-41-03 hl2 2024-01-23 19-01-47-79

ToxicHolyGrenade commented 10 months ago

hl2 2024-01-23 19-01-57-90 hl2 2024-01-23 19-08-45-41 hl2 2024-01-23 19-08-52-86 hl2 2024-01-23 19-09-01-31

ToxicHolyGrenade commented 10 months ago

hl2 2024-01-23 19-09-06-75 hl2 2024-01-23 19-09-13-35 hl2 2024-01-23 19-09-18-11 hl2 2024-01-23 19-09-38-42

ToxicHolyGrenade commented 10 months ago

hl2 2024-01-23 19-09-40-69 hl2 2024-01-23 19-09-56-52

penolakushari commented 10 months ago

Alrighty, the 2 checkboxes are for different modes of ragdoll mover, position gizmo for the moving arrows one, and angle gizmo is the discs one. Disabling those puts them in the world angles mode, as I did happen to write before, enabling them makes them align to the currently selected bone. Scaling gizmo doesn't have that as scaling stuff around world axises would be kinda weird.

In simpler terms, use upper checkbox to switch how the arrows are located, one below it for the discs rotation mode.

ToxicHolyGrenade commented 10 months ago

I am aware of that, but I checked them on and off, but still the same problem. It is either the problem with Garry's Mod's fundamental errors causing this, or the stand tool. Because you did insist that there is nothing wrong with the ragdoll mover tool probably, then it is the other tools causing it, to which I have mentioned already in this very comment.

Thespikedballofdoom commented 10 months ago

What is the misalignment anyway? is it that it is in world space, as in not in localized mode, or that the arrows aren't perfectly straight downward when in localized mode? Many model pelvis bones are oriented at an odd angle by default in their true standing mode.

ToxicHolyGrenade commented 10 months ago

What is the misalignment anyway? is it that it is in world space, as in not in localized mode, or that the arrows aren't perfectly straight downward when in localized mode? Many model pelvis bones are oriented at an odd angle by default in their true standing mode.

Not just the misalignment of the angle and position gizmos, but also the results of the position gizmos not being correctly straight, as shown in one of the images.

Thespikedballofdoom commented 10 months ago

Which image. Again if they aren't perfectly downward, that's probably the pelvis being oriented in the default pose

ToxicHolyGrenade commented 10 months ago

Which image. Again if they aren't perfectly downward, that's probably the pelvis being oriented in the default pose

https://private-user-images.githubusercontent.com/83011225/299076073-3526ee28-878b-4c3b-b899-48f0116392fc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDYxODg2NDAsIm5iZiI6MTcwNjE4ODM0MCwicGF0aCI6Ii84MzAxMTIyNS8yOTkwNzYwNzMtMzUyNmVlMjgtODc4Yi00YzNiLWI4OTktNDhmMDExNjM5MmZjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTI1VDEzMTIyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZmYmRlMjk2NDBkYTIyZTFhOGE5ZmZlYTA4YTcyZmIwZWZjY2I4MmVlNTQ0NjlkNGU5Yzc5YzRmMTc5YzcwYjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.np9vWR3I7qD0MdsBSy_FWD7FDQCagATxpXOdTU9B_-8

The pelvis is perfectly fine, but that doesn't change the fact that the gizmos in this image here is misaligned and broken.

Thespikedballofdoom commented 10 months ago

It isn't misaligned. image This is what it looks like for me, how it's supposed to be oriented when localized angles are on. Check out scout's .qc: image It's rotated by default.

ToxicHolyGrenade commented 10 months ago

It isn't misaligned. image This is what it looks like for me, how it's supposed to be oriented when localized angles are on. Check out scout's .qc: image It's rotated by default.

Is there any way we can patch this out, both Garry's Mod and all the other Scout based ragdolls? Should we encourage the addon creators to do the same?

penolakushari commented 10 months ago

That's why world orientation is a thing, in case you want to move stuff up or down without caring how bone is rotated, or to rotate a foot in IK rig for example

ToxicHolyGrenade commented 10 months ago

It isn't misaligned. image This is what it looks like for me, how it's supposed to be oriented when localized angles are on. Check out scout's .qc: image It's rotated by default.

Would it be a good idea to do so?

ToxicHolyGrenade commented 9 months ago

It isn't misaligned. image This is what it looks like for me, how it's supposed to be oriented when localized angles are on. Check out scout's .qc: image It's rotated by default.

If I want to change the pelvis value so it is perfectly straight in order to fix the misalignment problem, then what is the value exactly to do so? Where are the .qc files located?