WindhoverLabs / airliner

7 stars 3 forks source link

CF App has a "typo" bit operation when checking pdu packet #324

Open ynielson opened 1 year ago

ynielson commented 1 year ago

CF App has a "typo" bit operation when checking incoming pdu packet in the function, "pdu__is_this_pdu_acceptable()". It checked pdu_type by checking the File Directive byte, bit 4, as below: pdu_type = pdu->content[0] && 0x10; if (pdu_type == 0x00)

It used logical operation, "&&", instead of bit operation, "&". This didn't cause any error so far.