WindhoverLabs / airliner

7 stars 3 forks source link

CF app didn't extract the "file_transfer" option from the Incoming MD PDU. #330

Open ynielson opened 1 year ago

ynielson commented 1 year ago

When the CF app received the Incoming MD PDU, it didn't extract the "file_transfer" option from the MD PDU. It should extract the "file_transfer" option from the first bit( & 0x80) of byte 1 in the function, "pdu__md_struct_from_md_pdu". This "file_transfer" option was default set to "YES" in the later code, so it didn't cause any error so far.

It may be a typo, that it extracted the "segmentation_control" option from the first bit of byte 1(& 0x80), instead of the second bit (& 0x40). It is commented that the "segmentation_control" is not supported for Playback files. I am not sure if it is the same case for the Incoming PDUs.