WindhoverLabs / airliner

7 stars 3 forks source link

LD App didn't verify command length when received commands #350

Open ynielson opened 1 year ago

ynielson commented 1 year ago

When the LD app received the commands like "LD_MODE_AUTO_CC" and "LD_MODE_MANUAL_CC", it didn't verify the command length by calling the existing function, "VerifyCmdLength()". Even though these commands are the "LD_NoArgCmd_t" type, these commands are significant.

And just in case if this matters, the function, VerifyCmdLength(), sent the event message with msgID formatted "0x%08X" instead of "0x%04X". The MsgID is the type CFE_SB_MsgId_t(uint16) and usually printed as the format "0x%04X". But only this function, VerifyCmdLength(), printed it formatted "0x%08X" in most of the apps, except several apps like sch, to, ci_nasa, cs.