search

WindowTop / WindowTop-App

Set window on top, make it dark, transparent and more
Other
1.16k stars 69 forks source link

Window state restored when changing between desktops #128

Closed JaasielCR closed 3 years ago

JaasielCR commented 3 years ago

When you create a new desktop on your computer I mean whit ctrl+windows+D, and you set in top whatever window in the first desktop, when you change to desktop 2 and return, that window just isnt configure to be on top, you need to activate it again to be on top.

gileli121 commented 3 years ago

@JaasielCR Thanks for the report. I was able to reproduce the issue.

I will work on fix soon.

gileli121 commented 3 years ago

@JaasielCR After more investigation of the bug, the reason was that when it detected that the window is not on the active desktop, it triggered OnWindowUnlisted() of the current WindowItem

The method is designed to restore the window state to the original. This means that the bug is also valid for every other feature and not just the set-top feature.

I forgot to take into account that there is another type of "un-list" event.. in this type we should remove the window from the main list, but we should not fully forget it. Instead, should be another list that will hold these windows. Now in this event, it will not restore the window state, It will only hide some stuff such as red-border, anchors, etc, and will put it in a side list. And when the window becomes visible again it will move it from the side list to the main list so it will be processed.

Please try this build and let me know if it fixed and stable: WindowTop Build 27-08-21_2.zip

Thanks.

JaasielCR commented 3 years ago

Hi @gileli121

I already tried the new build and it looks that the issue was solved and also stable. Fixing that it also solved another issue that i had when minimized a zoom meeting while being on top.

But now i see another kind of bug when i change between desktops and i leave one window on top and return to that desktop, of course now it still on top, but when u dragged it the red boder appear and it doesnt move with the window just sill there floating in the nothing and to hide it you need to minimize the window and change again between desktops.

I hope you could check that, but im impressive and gratefull on how u fixed my problem.

Thanks and congrats.

gileli121 commented 3 years ago

@JaasielCR Great that it fixed for you.

About the new issue, I can't reproduce it. I tried these steps:

  1. Set window on top with a red border
  2. Switch to to another desktop
  3. Go back to the first desktop
  4. Drag the window

The red border did move with the window. So maybe I am missing something. Can you describe exactly the steps you did?

JaasielCR commented 3 years ago

@gileli121 Yeah of course

Maybe is also a misunderstanding, im not sure what you mean with "set on top with a red border", is it different that just "set it in top normal"? because i just set it in top like any other window, and there is no red border, but then when i do the steps 2,3 and 4 that you did the window suddenly appear with a red border and when continue dragging it the border still all the time in the orginial place of the window, it doesnt move with it.

To be more specific these are my steps:

  1. Set window on top (and there is no red border visible in this point)
  2. Switch to to another desktop
  3. Go back to the first desktop
  4. Drag the window
  5. (At this point is when the red border suddenly appear and it also stays in the place that i set the window on top, it doesnt move with the window)

I think that the bigger/first problem is that the red border just appear when it wasnt there and i dont need it nor wanted it, but also that then the border doesnt follow the window.

Thanks for your pacient and attention

gileli121 commented 3 years ago

@JaasielCR This was a better bug description! I reproduced it now. So the key point here is to disable the red border option here: image

I am checking now if your report is similar or the same as https://github.com/BiGilSoft/WindowTop/issues/122

That reported by another user

gileli121 commented 3 years ago

@JaasielCR We will continue to talk about the second issue here: https://github.com/BiGilSoft/WindowTop/issues/122

gileli121 commented 3 years ago

@JaasielCR Please try the new build that I posted in https://github.com/BiGilSoft/WindowTop/issues/122#issuecomment-907613800

And update me there if it fixed for you. Thanks