search

WindowTop / WindowTop-App

Set window on top, make it dark, transparent and more
Other
1.12k stars 68 forks source link

Integrate with minimize button not working with electron windows. #245

Closed rp1231 closed 2 years ago

rp1231 commented 2 years ago

The integrate with minimize button is not working on some windows. The notable ones are electron apps like slack, discord and vscode. It's also not working on the windowtop settings app window, Is windowtop built with electron?

gileli121 commented 2 years ago

@rp1231 Does Windows 11 snap layouts work with these windows?

Read more about it here https://thewincentral.com/windows-11-has-snap-layouts-with-3-columns-for-large-displays-improved-docking-multiple-monitor-experience/?amp

And no, WindowTop not built with electron. "electron" seems to solve the need for cross platform support for UI but all the magic that WindowTop does is too advanced and complicated for making cross platform code.. it built with C# and small part of it built with C++

rp1231 commented 2 years ago

No, snap layouts does not work with these electron windows..... But it's strange how it doesn't work with the windowtop settings window.... Especially since it's a native app. WindowTop_BwMtUCuuaI This is a screenshot of the settings window with the "integrate with minimize" option turned on. Still the arrow is shown in the middle similar to electron windows.

gileli121 commented 2 years ago

@rp1231 And also the OS will fail to detect in this window the maximize/restore button that used to show snap layouts popup.

I don't know how the OS does it (how exactly it detects these buttons) but I assume that the way I did it is very similar to how Windows 11 handle it internally.

I am not going to share with you my secrets if this is what you asking for. I know that you want this feature in PowerToys but I am not going to help in that in any way

rp1231 commented 2 years ago

I am not going to share with you my secrets if this is what you asking for. I know that you want this feature in PowerToys but I am not going to help in that in any way

I think you are misunderstanding me, I'm not trying to get secrets out of you. I'm not a programmer, I'm just a power user with a casual interest in software, so it was just a general thing I said.

All I'm looking for is an always on top app that has all the features I need and works on all windows.

The reason I posted this issue is that this software is very close to having all the features I want except for working on all the windows in the same way.

If I can find one software that works on all windows I can end my search.

gileli121 commented 2 years ago

@rp1231 Sorry for misunderstanding you. So what is missing? You want it to work for any window? That's it?

In such case, I can't deliver such level of functionality. Even the OS can't in this case

So you want that it will not show even the arrow in case that it failed to detect the minimize button (and you will use hotkey instead?

If anything else is missing let me know. My goal is to build the best window manager app :)

rp1231 commented 2 years ago

So what is missing? You want it to work for any window? That's it?

In such case, I can't deliver such level of functionality. Even the OS can't in this case

Yep that was all. I like the way it pops out of the minimize button, but it wasn't doing that for some windows.

I thought it was a bug, so I reported it.

Now that I know that it's not possible, I'll probably revert to using the arrow for all windows because I like having the same interaction for all windows.

It's annoying to remember a different interaction for some windows.

gileli121 commented 2 years ago

@rp1231 Ok You have a valid point.

One way around it is to configure the arrow to show on the right side (instead of center) of the window by default.

This way, you always find the trigger where the minimize button is located so even if you don't remember, you anyway should move the mouse to the minimize button.

Maybe it help

gileli121 commented 2 years ago

@rp1231 You know what, if "electron" windows are very common, i can write a specific detection method for these windows..

In all cases that it didn't work, it was another electron window?

With how many windows you tried it?

rp1231 commented 2 years ago

One way around it is to configure the arrow to show on the right side (instead of center) of the window by default.

This way, you always find the trigger where the minimize button is located so even if you don't remember, you anyway should move the mouse to the minimize button.

Yep this is what I'm using now and it seems like the best solution for now.